Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove the makeReasonSerializable helper function, and use wrapReason instead, in src/shared/message_handler.js

Browse Source 
Since `wrapReason` and `makeReasonSerializable` are essentially functionally equivalent it doesn't seem necessary to keep both of them around, especially when `makeReasonSerializable` only has a *single* call-site.
This commit is contained in:
Jonas Jenwald 2019-08-30 19:22:27 +02:00
parent 4e6a9b54c7
commit f71ea2de0e
1 changed files with 4 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/shared/message_handler.js
View File

@ -48,22 +48,13 @@ function wrapReason(reason) {
return new MissingPDFException(reason.message);
case 'UnexpectedResponseException':
return new UnexpectedResponseException(reason.message, reason.status);
default:
case 'UnknownErrorException':
return new UnknownErrorException(reason.message, reason.details);
default:
return new UnknownErrorException(reason.message, reason.toString());
}
}
function makeReasonSerializable(reason) {
if (!(reason instanceof Error) ||
reason instanceof AbortException ||
reason instanceof MissingPDFException ||
reason instanceof UnexpectedResponseException ||
reason instanceof UnknownErrorException) {
return reason;
}
return new UnknownErrorException(reason.message, reason.toString());
}
function resolveOrReject(capability, data) {
if (data.success) {
capability.resolve();
@ -125,7 +116,7 @@ function MessageHandler(sourceName, targetName, comObj) {
targetName,
isReply: true,
callbackId: data.callbackId,
error: makeReasonSerializable(reason),
error: wrapReason(reason),
});
});
} else if (data.streamId) {