Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[test/driver.js] Ensure that Image src is set *after* the callbacks in resolveImages

Browse Source 
*While I cannot guarantee that this will fix the recent intermittents, this patch really shouldn't hurt.*

By setting the Image `src` first, there's a small possibility that the Image is loaded *before* we've had a change to attach the `onload`/`onerror` callbacks which may cause the Promise to remain in a pending state.
Note that prior to PR 13641 we didn't correctly await all image resources to actually load, which could explain the very recent intermittent test-failures.
This commit is contained in:
Jonas Jenwald 2021-07-05 16:24:23 +02:00
parent b9e84ba70e
commit f6ce449fea
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
test/driver.js
View File

@ -97,7 +97,6 @@ async function resolveImages(node, silentErrors = false) {
const loadedPromises = []; const loadedPromises = [];
for (let i = 0, ii = data.length; i < ii; i++) { for (let i = 0, ii = data.length; i < ii; i++) {
images[i].src = data[i];
loadedPromises.push( loadedPromises.push(
new Promise(function (resolveImage, rejectImage) { new Promise(function (resolveImage, rejectImage) {
images[i].onload = resolveImage; images[i].onload = resolveImage;
@ -108,6 +107,7 @@ async function resolveImages(node, silentErrors = false) {
rejectImage(new Error("Error loading image " + e)); rejectImage(new Error("Error loading image " + e));
} }
}; };
images[i].src = data[i];
}) })
); );
} }