Merge pull request #11728 from Snuffleupagus/PDFDocumentProperties-constructor-props

Remove unnecessary checks from the `PDFDocumentProperties` constructor
This commit is contained in:
Tim van der Meij 2020-03-22 16:26:18 +01:00 committed by GitHub
commit f53db81c20
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -72,25 +72,21 @@ class PDFDocumentProperties {
this.l10n = l10n; this.l10n = l10n;
this._reset(); this._reset();
// Bind the event listener for the Close button.
closeButton.addEventListener("click", this.close.bind(this));
if (closeButton) {
// Bind the event listener for the Close button.
closeButton.addEventListener("click", this.close.bind(this));
}
this.overlayManager.register( this.overlayManager.register(
this.overlayName, this.overlayName,
this.container, this.container,
this.close.bind(this) this.close.bind(this)
); );
if (eventBus) { eventBus._on("pagechanging", evt => {
eventBus._on("pagechanging", evt => { this._currentPageNumber = evt.pageNumber;
this._currentPageNumber = evt.pageNumber; });
}); eventBus._on("rotationchanging", evt => {
eventBus._on("rotationchanging", evt => { this._pagesRotation = evt.pagesRotation;
this._pagesRotation = evt.pagesRotation; });
});
}
this._isNonMetricLocale = true; // The default viewer locale is 'en-us'. this._isNonMetricLocale = true; // The default viewer locale is 'en-us'.
l10n.getLanguage().then(locale => { l10n.getLanguage().then(locale => {