Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[GENERIC viewer] Generate the fileInput DOM-element dynamically

Browse Source 
Given that only the GENERIC viewer supports opening more than one PDF document, we can simplify things a tiny bit by instead generating the necessary DOM-element in JavaScript.
This commit is contained in:
Jonas Jenwald 2024-01-28 16:51:28 +01:00
parent 32a5bb83d4
commit f394031c1d
5 changed files with 6 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
web/app.js
View File

@ -602,8 +602,12 @@ const PDFViewerApplication = {
} }
if (typeof PDFJSDev === "undefined" || PDFJSDev.test("GENERIC")) { if (typeof PDFJSDev === "undefined" || PDFJSDev.test("GENERIC")) {
const fileInput = appConfig.openFileInput; const fileInput = (this._openFileInput = document.createElement("input"));
fileInput.id = "fileInput";
fileInput.hidden = true;
fileInput.type = "file";
fileInput.value = null; fileInput.value = null;
document.body.append(fileInput);
fileInput.addEventListener("change", function (evt) { fileInput.addEventListener("change", function (evt) {
const { files } = evt.target; const { files } = evt.target;
@ -2383,8 +2387,7 @@ if (typeof PDFJSDev === "undefined" || PDFJSDev.test("GENERIC")) {
// eslint-disable-next-line no-var // eslint-disable-next-line no-var
var webViewerOpenFile = function (evt) { var webViewerOpenFile = function (evt) {
const fileInput = PDFViewerApplication.appConfig.openFileInput; PDFViewerApplication._openFileInput?.click();
fileInput.click();
}; };
} }

5
web/viewer-geckoview.html
View File

@ -123,10 +123,5 @@ See https://github.com/adobe-type-tools/cmap-resources
</div> <!-- outerContainer --> </div> <!-- outerContainer -->
<div id="printContainer"></div> <div id="printContainer"></div>
<!--#if !MOZCENTRAL-->
<input type="file" id="fileInput" class="hidden">
<!--#endif-->
</body> </body>
</html> </html>

4
web/viewer-geckoview.js
View File

@ -57,10 +57,6 @@ function getViewerConfiguration() {
cancelButton: document.getElementById("passwordCancel"), cancelButton: document.getElementById("passwordCancel"),
}, },
printContainer: document.getElementById("printContainer"), printContainer: document.getElementById("printContainer"),
openFileInput:
typeof PDFJSDev === "undefined" || PDFJSDev.test("GENERIC")
? document.getElementById("fileInput")
: null,
}; };
} }

4
web/viewer.html
View File

@ -565,9 +565,5 @@ See https://github.com/adobe-type-tools/cmap-resources
</div> <!-- outerContainer --> </div> <!-- outerContainer -->
<div id="printContainer"></div> <div id="printContainer"></div>
<!--#if GENERIC-->
<input type="file" id="fileInput" class="hidden">
<!--#endif-->
</body> </body>
</html> </html>

4
web/viewer.js
View File

@ -177,10 +177,6 @@ function getViewerConfiguration() {
), ),
}, },
printContainer: document.getElementById("printContainer"), printContainer: document.getElementById("printContainer"),
openFileInput:
typeof PDFJSDev === "undefined" || PDFJSDev.test("GENERIC")
? document.getElementById("fileInput")
: null,
debuggerScriptPath: "./debugger.mjs", debuggerScriptPath: "./debugger.mjs",
}; };
} }