Merge pull request #94 from sayrer/master

Small fixes r=gal
This commit is contained in:
Andreas Gal 2011-06-26 11:16:47 -07:00
commit f08bff5578
2 changed files with 10 additions and 4 deletions

View File

@ -34,3 +34,5 @@ user_pref("dom.w3c_touch_events.enabled", true);
user_pref("extensions.checkCompatibility", false); user_pref("extensions.checkCompatibility", false);
user_pref("extensions.installDistroAddons", false); // prevent testpilot etc user_pref("extensions.installDistroAddons", false); // prevent testpilot etc
user_pref("browser.safebrowsing.enable", false); // prevent traffic to google servers user_pref("browser.safebrowsing.enable", false); // prevent traffic to google servers
user_pref("toolkit.telemetry.prompted", true); // prevent telemetry banner
user_pref("toolkit.telemetry.enabled", false);

View File

@ -37,6 +37,8 @@ class TestOptions(OptionParser):
options.manifestFile = DEFAULT_MANIFEST_FILE options.manifestFile = DEFAULT_MANIFEST_FILE
if options.browser and options.browserManifestFile: if options.browser and options.browserManifestFile:
print "Warning: ignoring browser argument since manifest file was also supplied" print "Warning: ignoring browser argument since manifest file was also supplied"
if not options.browser and not options.browserManifestFile:
self.error("No test browsers found. Use --browserManifest or --browser args.")
return options return options
def prompt(question): def prompt(question):
@ -220,8 +222,7 @@ def setUp(options):
testBrowsers = makeBrowserCommands(options.browserManifestFile) testBrowsers = makeBrowserCommands(options.browserManifestFile)
elif options.browser: elif options.browser:
testBrowsers = [BrowserCommand({"path":options.browser, "name":"firefox"})] testBrowsers = [BrowserCommand({"path":options.browser, "name":"firefox"})]
else: assert len(testBrowsers) > 0
print "No test browsers found. Use --browserManifest or --browser args."
with open(options.manifestFile) as mf: with open(options.manifestFile) as mf:
manifestList = json.load(mf) manifestList = json.load(mf)
@ -415,6 +416,7 @@ def processResults():
def main(): def main():
t1 = time.time()
optionParser = TestOptions() optionParser = TestOptions()
options, args = optionParser.parse_args() options, args = optionParser.parse_args()
options = optionParser.verifyOptions(options) options = optionParser.verifyOptions(options)
@ -434,6 +436,8 @@ def main():
processResults() processResults()
finally: finally:
teardownBrowsers(browsers) teardownBrowsers(browsers)
t2 = time.time()
print "Runtime was", int(t2 - t1), "seconds"
if __name__ == '__main__': if __name__ == '__main__':
main() main()