Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove the deprecated ways, in BaseViewer, of setting the Scroll/Spread modes (PR 9858 follow-up)

Browse Source 
Considering that a number of `[api-minor]` changes have landed since PR 9858, removing this code ought to be OK now (the less time these methods remain exposed, the better); implements https://github.com/mozilla/pdf.js/pull/9858#issuecomment-401730065.
This commit is contained in:
Jonas Jenwald 2018-08-20 14:11:47 +02:00
parent 4ea663aa8a
commit eef70c1eae
1 changed files with 0 additions and 29 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
web/base_viewer.js
View File

@ -171,19 +171,6 @@ class BaseViewer {
if (this.removePageBorders) { if (this.removePageBorders) {
this.viewer.classList.add('removePageBorders'); this.viewer.classList.add('removePageBorders');
} }
if ((typeof PDFJSDev === 'undefined' || PDFJSDev.test('GENERIC')) &&
('scrollMode' in options || 'spreadMode' in options)) {
console.error(`The ${this._name} constructor options ` +
'`scrollMode`/`spreadMode` are deprecated, use the setters instead.');
if (options.scrollMode !== undefined) {
this.scrollMode = options.scrollMode;
}
if (options.spreadMode !== undefined) {
this.spreadMode = options.spreadMode;
}
}
// Defer the dispatching of this event, to give other viewer components // Defer the dispatching of this event, to give other viewer components
// time to initialize *and* register 'baseviewerinit' event listeners. // time to initialize *and* register 'baseviewerinit' event listeners.
Promise.resolve().then(() => { Promise.resolve().then(() => {
@ -1080,14 +1067,6 @@ class BaseViewer {
this.update(); this.update();
} }
setScrollMode(mode) {
if (typeof PDFJSDev === 'undefined' || PDFJSDev.test('GENERIC')) {
console.error(`${this._name}.setScrollMode() is deprecated, ` +
`use the ${this._name}.scrollMode setter instead.`);
this.scrollMode = mode;
}
}
/** /**
* @return {number} One of the values in {SpreadMode}. * @return {number} One of the values in {SpreadMode}.
*/ */
@ -1147,14 +1126,6 @@ class BaseViewer {
this.scrollPageIntoView({ pageNumber, }); this.scrollPageIntoView({ pageNumber, });
this.update(); this.update();
} }
setSpreadMode(mode) {
if (typeof PDFJSDev === 'undefined' || PDFJSDev.test('GENERIC')) {
console.error(`${this._name}.setSpreadMode() is deprecated, ` +
`use the ${this._name}.spreadMode setter instead.`);
this.spreadMode = mode;
}
}
} }
export { export {