From eed67ea8bbba61a05877a99dc2f03b5adad5a288 Mon Sep 17 00:00:00 2001 From: Jonas Jenwald Date: Sun, 8 Feb 2015 17:40:52 +0100 Subject: [PATCH] Remove the |el| property in PDFPageView and PDFThumbnailView --- web/pdf_page_view.js | 1 - web/pdf_thumbnail_view.js | 1 - web/ui_utils.js | 8 ++++---- 3 files changed, 4 insertions(+), 6 deletions(-) diff --git a/web/pdf_page_view.js b/web/pdf_page_view.js index 468d30d3c..8e49cbaf6 100644 --- a/web/pdf_page_view.js +++ b/web/pdf_page_view.js @@ -80,7 +80,6 @@ var PDFPageView = (function PDFPageViewClosure() { div.className = 'page'; div.style.width = Math.floor(this.viewport.width) + 'px'; div.style.height = Math.floor(this.viewport.height) + 'px'; - this.el = div; // TODO replace 'el' property usage this.div = div; container.appendChild(div); diff --git a/web/pdf_thumbnail_view.js b/web/pdf_thumbnail_view.js index dc5da0f83..d83d30d1f 100644 --- a/web/pdf_thumbnail_view.js +++ b/web/pdf_thumbnail_view.js @@ -99,7 +99,6 @@ var PDFThumbnailView = (function PDFThumbnailViewClosure() { var div = document.createElement('div'); div.id = 'thumbnailContainer' + id; div.className = 'thumbnail'; - this.el = div; // TODO: replace 'el' property usage. this.div = div; if (id === 1) { diff --git a/web/ui_utils.js b/web/ui_utils.js index 3c32c5939..00eb25e0e 100644 --- a/web/ui_utils.js +++ b/web/ui_utils.js @@ -194,16 +194,16 @@ function getVisibleElements(scrollEl, views, sortByVisibility) { var currentWidth, viewWidth; for (var i = 0, ii = views.length; i < ii; ++i) { view = views[i]; - currentHeight = view.el.offsetTop + view.el.clientTop; - viewHeight = view.el.clientHeight; + currentHeight = view.div.offsetTop + view.div.clientTop; + viewHeight = view.div.clientHeight; if ((currentHeight + viewHeight) < top) { continue; } if (currentHeight > bottom) { break; } - currentWidth = view.el.offsetLeft + view.el.clientLeft; - viewWidth = view.el.clientWidth; + currentWidth = view.div.offsetLeft + view.div.clientLeft; + viewWidth = view.div.clientWidth; if ((currentWidth + viewWidth) < left || currentWidth > right) { continue; }