From ee2896dd1ebc5f19563f98b74faa2f0acc57f1c2 Mon Sep 17 00:00:00 2001 From: Jonas Jenwald Date: Mon, 14 Mar 2022 14:36:38 +0100 Subject: [PATCH] Remove the custom `grab`/`grabbing` cursor image files According to the MDN compatibility data, see https://developer.mozilla.org/en-US/docs/Web/CSS/cursor#browser_compatibility, all browsers that we now support should have these cursors available natively. --- gulpfile.js | 11 ++--------- web/images/grab.cur | Bin 326 -> 0 bytes web/images/grabbing.cur | Bin 326 -> 0 bytes web/viewer.css | 2 -- 4 files changed, 2 insertions(+), 11 deletions(-) delete mode 100644 web/images/grab.cur delete mode 100644 web/images/grabbing.cur diff --git a/gulpfile.js b/gulpfile.js index 48fe10288..c4d54996e 100644 --- a/gulpfile.js +++ b/gulpfile.js @@ -63,7 +63,7 @@ const DIST_DIR = BUILD_DIR + "dist/"; const TYPES_DIR = BUILD_DIR + "types/"; const TMP_DIR = BUILD_DIR + "tmp/"; const TYPESTEST_DIR = BUILD_DIR + "typestest/"; -const COMMON_WEB_FILES = ["web/images/*.{png,svg,gif,cur}", "web/debugger.js"]; +const COMMON_WEB_FILES = ["web/images/*.{png,svg,gif}", "web/debugger.js"]; const MOZCENTRAL_DIFF_FILE = "mozcentral.diff"; const REPO = "git@github.com:mozilla/pdf.js.git"; @@ -1215,13 +1215,6 @@ gulp.task( const version = versionJSON.version, commit = versionJSON.commit; - // Ignore the fallback cursor images, since they're unnecessary in - // Firefox. - const MOZCENTRAL_COMMON_WEB_FILES = [ - ...COMMON_WEB_FILES, - "!web/images/*.cur", - ]; - return merge([ createMainBundle(defines).pipe( gulp.dest(MOZCENTRAL_CONTENT_DIR + "build") @@ -1239,7 +1232,7 @@ gulp.task( gulp.dest(MOZCENTRAL_CONTENT_DIR + "web") ), gulp - .src(MOZCENTRAL_COMMON_WEB_FILES, { base: "web/" }) + .src(COMMON_WEB_FILES, { base: "web/" }) .pipe(gulp.dest(MOZCENTRAL_CONTENT_DIR + "web")), createCMapBundle().pipe( gulp.dest(MOZCENTRAL_CONTENT_DIR + "web/cmaps") diff --git a/web/images/grab.cur b/web/images/grab.cur deleted file mode 100644 index db7ad5aed3ef958aa13903afa769386382a87ad3..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 326 zcmajZAr8Vo5QX7?si;7#!yvj6Nx}i(CG{p)>hLyxD99 z76ej)=-vic0UL9~!GgO~9_MsOnufoUx`QHG)5E@a!o?nT8@#*2`fMlI9X~2&%Qwtd fAElzRww7{H`T9z)QIL|gUwP@h-(DMO`2YPI1=f8x diff --git a/web/images/grabbing.cur b/web/images/grabbing.cur deleted file mode 100644 index e0dfd04e4d3fcbaa6588c8cbb9e9065609bcb862..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 326 zcmZQzU}9ioP*7lC;0HnjMg|5k1_lNVAO;FCH~=vt5Q0Dhn8YOh|NoCEh)sn30RsaF z^8>N`2L=Xv5dHz=L$Uk|1_tQ_266z<4TQl5{{R0$_yG_fVE_NW0fd=>Y#@FBr9t9P K<`XsxO$7j30D*Y` diff --git a/web/viewer.css b/web/viewer.css index 84d1cd1e2..2f658eaaf 100644 --- a/web/viewer.css +++ b/web/viewer.css @@ -1699,7 +1699,6 @@ html[dir="rtl"] .treeItemToggler::before { } .grab-to-pan-grab { - cursor: url("images/grab.cur"), move !important; cursor: grab !important; } .grab-to-pan-grab @@ -1708,7 +1707,6 @@ html[dir="rtl"] .treeItemToggler::before { } .grab-to-pan-grab:active, .grab-to-pan-grabbing { - cursor: url("images/grabbing.cur"), move !important; cursor: grabbing !important; position: fixed; background: rgba(0, 0, 0, 0);