Merge pull request #14131 from Snuffleupagus/spreadMode-render-holes

Ensure that pre-rendering works correctly with spreadModes at higher zoom levels
This commit is contained in:
Tim van der Meij 2021-10-15 21:20:06 +02:00 committed by GitHub
commit ed3da19869
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -126,10 +126,24 @@ class PDFRenderingQueue {
return view;
}
}
const firstId = visible.first.id,
lastId = visible.last.id;
// All the visible views have rendered; try to handle any "holes" in the
// page layout (can happen e.g. with spreadModes at higher zoom levels).
if (lastId - firstId > 1) {
for (let i = 0, ii = lastId - firstId; i <= ii; i++) {
const holeId = scrolledDown ? firstId + i : lastId - i,
holeView = views[holeId - 1];
if (!this.isViewFinished(holeView)) {
return holeView;
}
}
}
// All the visible views have rendered; try to render next/previous page.
// (IDs start at 1, so no need to add 1 when `scrolledDown === true`.)
let preRenderIndex = scrolledDown ? visible.last.id : visible.first.id - 2;
let preRenderIndex = scrolledDown ? lastId : firstId - 2;
let preRenderView = views[preRenderIndex];
if (preRenderView && !this.isViewFinished(preRenderView)) {