From ecd3de83f8a4846cc264d624f701e6fc682bce53 Mon Sep 17 00:00:00 2001 From: Jonas Jenwald Date: Sun, 12 Jan 2020 14:50:52 +0100 Subject: [PATCH] Enable the ESLint `no-unneeded-ternary` rule This rule is already enabled in mozilla-central, see https://searchfox.org/mozilla-central/rev/b04e3a28a2ef4dbf957018dbbdc1840d62fdbc32/tools/lint/eslint/eslint-plugin-mozilla/lib/configs/recommended.js#247-248 Please see https://eslint.org/docs/rules/no-unneeded-ternary for additional information. --- .eslintrc | 1 + web/base_viewer.js | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/.eslintrc b/.eslintrc index cad57471c..a6c315c2d 100644 --- a/.eslintrc +++ b/.eslintrc @@ -138,6 +138,7 @@ "no-multiple-empty-lines": ["error", { "max": 1, "maxEOF": 0, "maxBOF": 1, }], "no-nested-ternary": "off", "no-new-object": "error", + "no-unneeded-ternary": "error", "spaced-comment": ["error", "always", { "block": { "balanced": true, diff --git a/web/base_viewer.js b/web/base_viewer.js index f93985899..78ab1fad9 100644 --- a/web/base_viewer.js +++ b/web/base_viewer.js @@ -768,7 +768,7 @@ class BaseViewer { height = 0, widthScale, heightScale; - const changeOrientation = pageView.rotation % 180 === 0 ? false : true; + const changeOrientation = pageView.rotation % 180 !== 0; const pageWidth = (changeOrientation ? pageView.height : pageView.width) / pageView.scale /