From e7da8edb91881872062121dc092fbc29d45327fe Mon Sep 17 00:00:00 2001 From: Manuel Braun Date: Mon, 14 Apr 2014 19:05:21 +0200 Subject: [PATCH] Refactoring - remove duplicated code in TextLayerBuilder --- web/text_layer_builder.js | 21 ++++++--------------- 1 file changed, 6 insertions(+), 15 deletions(-) diff --git a/web/text_layer_builder.js b/web/text_layer_builder.js index bd75abf63..19acbc0ba 100644 --- a/web/text_layer_builder.js +++ b/web/text_layer_builder.js @@ -238,26 +238,17 @@ var TextLayerBuilder = function textLayerBuilder(options) { var divIdx = begin.divIdx; var div = textDivs[divIdx]; div.textContent = ''; - - var content = bidiTexts[divIdx].str.substring(0, begin.offset); - var node = document.createTextNode(content); - if (className) { - var isSelected = isSelectedPage && - divIdx === selectedMatchIdx; - var span = document.createElement('span'); - span.className = className + (isSelected ? ' selected' : ''); - span.appendChild(node); - div.appendChild(span); - return; - } - div.appendChild(node); + appendTextToDiv(divIdx, 0, begin.offset, className); } function appendText(from, to, className) { - var divIdx = from.divIdx; + appendTextToDiv(from.divIdx, from.offset, to.offset, className); + } + + function appendTextToDiv(divIdx, fromOffset, toOffset, className) { var div = textDivs[divIdx]; - var content = bidiTexts[divIdx].str.substring(from.offset, to.offset); + var content = bidiTexts[divIdx].str.substring(fromOffset, toOffset); var node = document.createTextNode(content); if (className) { var span = document.createElement('span');