From a969440af821124d49cd30e726d3389a3b78fdc7 Mon Sep 17 00:00:00 2001 From: Brendan Dahl Date: Fri, 25 Feb 2022 09:55:52 -0800 Subject: [PATCH] Don't close window from test driver. Sometimes I get a "Unable to find target with id XXX closeTarget..." error when running tests which happens when test.js tries to close all the open pages. I haven't been able to fully verify since this is intermittent, but I think this is coming from us closing the window in driver.js and also trying to close it in test.js. --- test/driver.js | 5 ----- 1 file changed, 5 deletions(-) diff --git a/test/driver.js b/test/driver.js index ab9363d04..0cd912f2e 100644 --- a/test/driver.js +++ b/test/driver.js @@ -850,11 +850,6 @@ class Driver { // Send the quit request const r = new XMLHttpRequest(); r.open("POST", `/tellMeToQuit?browser=${escape(this.browser)}`, false); - r.onreadystatechange = function (e) { - if (r.readyState === 4) { - window.close(); - } - }; r.send(null); }