Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove the unused PDFViewerApplication.documentFingerprint property

Browse Source 
This property isn't accessed anywhere in the `web/app.js` file, and is also not being reset in `PDFViewerApplication.close`. Hence it seems that it can simply be removed, especially since the fingerprint is already synchronously available through `PDFViewerApplication.pdfDocument.fingerprint` (provided that a document is loaded).
This commit is contained in:
Jonas Jenwald 2018-06-29 13:02:23 +02:00
parent 99f8f2c275
commit e522b2d87e
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
web/app.js
View File

@ -973,8 +973,7 @@ let PDFViewerApplication = {
this.toolbar.setPagesCount(pdfDocument.numPages, false); this.toolbar.setPagesCount(pdfDocument.numPages, false);
this.secondaryToolbar.setPagesCount(pdfDocument.numPages); this.secondaryToolbar.setPagesCount(pdfDocument.numPages);
let id = this.documentFingerprint = pdfDocument.fingerprint; const store = this.store = new ViewHistory(pdfDocument.fingerprint);
let store = this.store = new ViewHistory(id);
let baseDocumentUrl; let baseDocumentUrl;
if (typeof PDFJSDev === 'undefined' || PDFJSDev.test('GENERIC')) { if (typeof PDFJSDev === 'undefined' || PDFJSDev.test('GENERIC')) {
@ -1003,7 +1002,7 @@ let PDFViewerApplication = {
// The browsing history is only enabled when the viewer is standalone, // The browsing history is only enabled when the viewer is standalone,
// i.e. not when it is embedded in a web page. // i.e. not when it is embedded in a web page.
let resetHistory = !AppOptions.get('showPreviousViewOnLoad'); let resetHistory = !AppOptions.get('showPreviousViewOnLoad');
this.pdfHistory.initialize(id, resetHistory); this.pdfHistory.initialize(pdfDocument.fingerprint, resetHistory);
if (this.pdfHistory.initialBookmark) { if (this.pdfHistory.initialBookmark) {
this.initialBookmark = this.pdfHistory.initialBookmark; this.initialBookmark = this.pdfHistory.initialBookmark;