Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Prevent browser console errors during testing

Browse Source 
The `Driver._cleanup` method is removing all stylesheets between test runs, which causes "TypeError: styleElement.parentNode is null" console errors in `FontLoader.clear`.

As can also be seen during various tests, some of the changes I made in PR 7972 unfortunately causes console errors.
It seems that I didn't test this properly, since it *should* have been obvious to me that while tests are triggered using Node.js, the files in question are run within the *browser*.
My apologies for not testing this thoroughly, and for causing unnecessary churn in the code!
This commit is contained in:
Jonas Jenwald 2017-02-05 13:23:42 +01:00
parent cae8d97c4c
commit e416032b38
4 changed files with 9 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/display/font_loader.js
View File

@ -61,7 +61,10 @@ FontLoader.prototype = {
clear: function fontLoaderClear() { clear: function fontLoaderClear() {
var styleElement = this.styleElement; var styleElement = this.styleElement;
if (styleElement) { if (styleElement) {
if (styleElement.parentNode) {
// Prevent "TypeError: styleElement.parentNode is null" during testing.
styleElement.parentNode.removeChild(styleElement); styleElement.parentNode.removeChild(styleElement);
}
styleElement = this.styleElement = null; styleElement = this.styleElement = null;
} }
if (typeof PDFJSDev === 'undefined' || !PDFJSDev.test('MOZCENTRAL')) { if (typeof PDFJSDev === 'undefined' || !PDFJSDev.test('MOZCENTRAL')) {

4
test/driver.js
View File

@ -251,7 +251,7 @@ var rasterizeAnnotationLayer = (function rasterizeAnnotationLayerClosure() {
/** /**
* @class * @class
*/ */
var Driver = (function DriverClosure() { var Driver = (function DriverClosure() { // eslint-disable-line no-unused-vars
/** /**
* @constructs Driver * @constructs Driver
* @param {DriverOptions} options * @param {DriverOptions} options
@ -685,5 +685,3 @@ var Driver = (function DriverClosure() {
return Driver; return Driver;
})(); })();
exports.Driver = Driver;

10
test/font/fontutils.js
View File

@ -19,7 +19,7 @@
var base64alphabet = var base64alphabet =
'ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/='; 'ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/=';
function decodeFontData(base64) { function decodeFontData(base64) { // eslint-disable-line no-unused-vars
var result = []; var result = [];
var bits = 0, bitsLength = 0; var bits = 0, bitsLength = 0;
@ -62,7 +62,7 @@ function encodeFontData(data) {
return buffer; return buffer;
} }
function ttx(data, callback) { function ttx(data, callback) { // eslint-disable-line no-unused-vars
var xhr = new XMLHttpRequest(); var xhr = new XMLHttpRequest();
xhr.open('POST', '/ttx'); xhr.open('POST', '/ttx');
@ -82,13 +82,9 @@ function ttx(data, callback) {
xhr.send(encodedData); xhr.send(encodedData);
} }
function verifyTtxOutput(output) { function verifyTtxOutput(output) { // eslint-disable-line no-unused-vars
var m = /^<error>(.*?)<\/error>/.exec(output); var m = /^<error>(.*?)<\/error>/.exec(output);
if (m) { if (m) {
throw m[1]; throw m[1];
} }
} }
exports.decodeFontData = decodeFontData;
exports.ttx = ttx;
exports.verifyTtxOutput = verifyTtxOutput;

3
test/unit/testreporter.js
View File

@ -1,5 +1,6 @@
'use strict'; 'use strict';
// eslint-disable-next-line no-unused-vars
var TestReporter = function(browser, appPath) { var TestReporter = function(browser, appPath) {
function send(action, json, cb) { function send(action, json, cb) {
var r = new XMLHttpRequest(); var r = new XMLHttpRequest();
@ -74,5 +75,3 @@ var TestReporter = function(browser, appPath) {
setTimeout(sendQuitRequest, 500); setTimeout(sendQuitRequest, 500);
}; };
}; };
exports.TestReporter = TestReporter;