From 9adb225a7d4eca3b5ed695513e41b669cd6939d7 Mon Sep 17 00:00:00 2001 From: Jonas Jenwald Date: Sat, 12 Dec 2020 12:41:47 +0100 Subject: [PATCH] Call `done.fail` correctly in the `scripting_spec.js` unit-tests The `done.fail` method should *always* be called with a reason, to ensure that any errors are propagated as intended to the test results. --- test/unit/scripting_spec.js | 36 ++++++++++++++++++------------------ 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/test/unit/scripting_spec.js b/test/unit/scripting_spec.js index 617552e7e..c999b28c0 100644 --- a/test/unit/scripting_spec.js +++ b/test/unit/scripting_spec.js @@ -749,8 +749,8 @@ describe("Scripting", function () { }); done(); - } catch (_) { - done.fail(); + } catch (ex) { + done.fail(ex); } }); }); @@ -793,8 +793,8 @@ describe("Scripting", function () { valueAsString: "123456.789", }); done(); - } catch (_) { - done.fail(); + } catch (ex) { + done.fail(ex); } }); @@ -834,8 +834,8 @@ describe("Scripting", function () { value: "Invalid number in [ MyField ]", }); done(); - } catch (_) { - done.fail(); + } catch (ex) { + done.fail(ex); } }); }); @@ -893,8 +893,8 @@ describe("Scripting", function () { }); done(); - } catch (_) { - done.fail(); + } catch (ex) { + done.fail(ex); } }); }); @@ -948,8 +948,8 @@ describe("Scripting", function () { }); done(); - } catch (_) { - done.fail(); + } catch (ex) { + done.fail(ex); } }); }); @@ -990,8 +990,8 @@ describe("Scripting", function () { }); done(); - } catch (_) { - done.fail(); + } catch (ex) { + done.fail(ex); } }); @@ -1029,8 +1029,8 @@ describe("Scripting", function () { }); done(); - } catch (_) { - done.fail(); + } catch (ex) { + done.fail(ex); } }); }); @@ -1124,8 +1124,8 @@ describe("Scripting", function () { }); done(); - } catch (_) { - done.fail(); + } catch (ex) { + done.fail(ex); } }); }); @@ -1202,8 +1202,8 @@ describe("Scripting", function () { }); done(); - } catch (_) { - done.fail(); + } catch (ex) { + done.fail(ex); } }); });