Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Simplify the ReadableStream polyfill

Browse Source 
At this point in time, all of the supported browsers (in the PDF.js project) have native `ReadableStream` implementations; see https://developer.mozilla.org/en-US/docs/Web/API/ReadableStream#browser_compatibility

Hence the polyfill is *only* necessary in Node.js environments now, and we shouldn't need to do any detailed feature detection either (since that was only done for the non-Chromium versions of the MS Edge browser).
Finally, we can slightly reduce the size of the Chromium-extension since the polyfill shouldn't be needed there either.
This commit is contained in:
Jonas Jenwald 2021-08-13 12:26:54 +02:00
parent 14a0d612c4
commit e2aa067603
1 changed files with 7 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
src/shared/compatibility.js
View File

@ -20,8 +20,8 @@ if (
(typeof PDFJSDev === "undefined" || !PDFJSDev.test("SKIP_BABEL")) && (typeof PDFJSDev === "undefined" || !PDFJSDev.test("SKIP_BABEL")) &&
(typeof globalThis === "undefined" || !globalThis._pdfjsCompatibilityChecked) (typeof globalThis === "undefined" || !globalThis._pdfjsCompatibilityChecked)
) { ) {
// Provides support for globalThis in legacy browsers. // Provides support for `globalThis` in legacy browsers.
// Support: Firefox<65, Chrome<71, Safari<12.1 // Support: Firefox<65, Chrome<71, Safari<12.1, Node.js<12.0.0
if (typeof globalThis === "undefined" || globalThis.Math !== Math) { if (typeof globalThis === "undefined" || globalThis.Math !== Math) {
// eslint-disable-next-line no-global-assign // eslint-disable-next-line no-global-assign
globalThis = require("core-js/es/global-this"); globalThis = require("core-js/es/global-this");
@ -89,23 +89,12 @@ if (
// shouldn't need to be polyfilled for the IMAGE_DECODERS build target. // shouldn't need to be polyfilled for the IMAGE_DECODERS build target.
return; return;
} }
let isReadableStreamSupported = false; if (typeof PDFJSDev !== "undefined" && PDFJSDev.test("CHROME")) {
// Slightly reduce the size of the Chromium-extension, given
if (typeof ReadableStream !== "undefined") { // that `ReadableStream` has been supported since Chrome 43.
// MS Edge may say it has ReadableStream but they are not up to spec yet. return;
try {
// eslint-disable-next-line no-new
new ReadableStream({
start(controller) {
controller.close();
},
});
isReadableStreamSupported = true;
} catch (e) {
// The ReadableStream constructor cannot be used.
}
} }
if (isReadableStreamSupported) { if (globalThis.ReadableStream || !isNodeJS) {
return; return;
} }
globalThis.ReadableStream = globalThis.ReadableStream =