From e16e072cb3caea1f5d5045e8a59198644120cd34 Mon Sep 17 00:00:00 2001 From: Jonas Jenwald Date: Fri, 9 Nov 2018 10:16:40 +0100 Subject: [PATCH] Directly call `_setCurrentPageNumber` when updating the Scroll/Spread modes in `BaseViewer` Given that the `_updateScrollMode`/`_updateSpreadMode` methods are "private", there's no particular reason to not just directly call `_setCurrentPageNumber`. --- web/base_viewer.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/web/base_viewer.js b/web/base_viewer.js index 730e9ff94..352fe1c81 100644 --- a/web/base_viewer.js +++ b/web/base_viewer.js @@ -1086,7 +1086,7 @@ class BaseViewer { if (this._currentScaleValue && isNaN(this._currentScaleValue)) { this._setScale(this._currentScaleValue, true); } - this.scrollPageIntoView({ pageNumber, }); + this._setCurrentPageNumber(pageNumber, /* resetCurrentPageView = */ true); this.update(); } @@ -1146,7 +1146,7 @@ class BaseViewer { if (!pageNumber) { return; } - this.scrollPageIntoView({ pageNumber, }); + this._setCurrentPageNumber(pageNumber, /* resetCurrentPageView = */ true); this.update(); } }