Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove the fancy-log dependency

Browse Source 
This dependency hasn't been updated in two years and the only place that
uses it is the `externaltest` target in the Gulpfile. We can simply
replace `fancy-log` usage there with `console.log` like we do in all
other places in the Gulpfile because we're not interested in the
timestamps here. Gulp already prints timestamps and these tests finish
within a second anyway.

Note that it remains in `package-lock.json` because other Gulp-related
packages have it as a dependency, but at least we're no longer depending
on it directly anymore now.
This commit is contained in:
Tim van der Meij 2020-10-04 17:30:39 +02:00
parent 910772cfcf
commit e0c80a3556
No known key found for this signature in database
GPG Key ID: 8C3FD2925A5F2762
2 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
gulpfile.js
View File

@ -21,7 +21,6 @@
var autoprefixer = require("autoprefixer"); var autoprefixer = require("autoprefixer");
var calc = require("postcss-calc"); var calc = require("postcss-calc");
var cssvariables = require("postcss-css-variables"); var cssvariables = require("postcss-css-variables");
var fancylog = require("fancy-log");
var fs = require("fs"); var fs = require("fs");
var gulp = require("gulp"); var gulp = require("gulp");
var postcss = require("gulp-postcss"); var postcss = require("gulp-postcss");
@ -1962,11 +1961,14 @@ gulp.task(
); );
gulp.task("externaltest", function (done) { gulp.task("externaltest", function (done) {
fancylog("Running test-fixtures.js"); console.log();
console.log("### Running test-fixtures.js");
safeSpawnSync("node", ["external/builder/test-fixtures.js"], { safeSpawnSync("node", ["external/builder/test-fixtures.js"], {
stdio: "inherit", stdio: "inherit",
}); });
fancylog("Running test-fixtures_esprima.js");
console.log();
console.log("### Running test-fixtures_esprima.js");
safeSpawnSync("node", ["external/builder/test-fixtures_esprima.js"], { safeSpawnSync("node", ["external/builder/test-fixtures_esprima.js"], {
stdio: "inherit", stdio: "inherit",
}); });

1
package.json
View File

@ -26,7 +26,6 @@
"eslint-plugin-no-unsanitized": "^3.1.4", "eslint-plugin-no-unsanitized": "^3.1.4",
"eslint-plugin-prettier": "^3.1.4", "eslint-plugin-prettier": "^3.1.4",
"eslint-plugin-unicorn": "^20.1.0", "eslint-plugin-unicorn": "^20.1.0",
"fancy-log": "^1.3.3",
"globals": "^11.12.0", "globals": "^11.12.0",
"gulp": "^4.0.2", "gulp": "^4.0.2",
"gulp-postcss": "^8.0.0", "gulp-postcss": "^8.0.0",