From e09310d7a450bfff4ff2b03e828a90b6eecfa8ba Mon Sep 17 00:00:00 2001 From: Jonas Jenwald Date: Fri, 22 Nov 2019 13:46:44 +0100 Subject: [PATCH] Remove `document.attachEvent` code from `web/pdf_print_service.js` since it's only necessary for old IE versions This code was originally added to support IE10 (and below), however with those browsers *explicitly* unsupported since PDF.js version `2.0` this code is now dead. --- web/pdf_print_service.js | 19 ++----------------- 1 file changed, 2 insertions(+), 17 deletions(-) diff --git a/web/pdf_print_service.js b/web/pdf_print_service.js index d6b9758d9..6a1ae2eb7 100644 --- a/web/pdf_print_service.js +++ b/web/pdf_print_service.js @@ -273,19 +273,14 @@ function renderProgress(index, total, l10n) { }); } -let hasAttachEvent = !!document.attachEvent; - window.addEventListener('keydown', function(event) { // Intercept Cmd/Ctrl + P in all browsers. // Also intercept Cmd/Ctrl + Shift + P in Chrome and Opera if (event.keyCode === /* P= */ 80 && (event.ctrlKey || event.metaKey) && !event.altKey && (!event.shiftKey || window.chrome || window.opera)) { window.print(); - if (hasAttachEvent) { - // Only attachEvent can cancel Ctrl + P dialog in IE <=10 - // attachEvent is gone in IE11, so the dialog will re-appear in IE11. - return; - } + + // The (browser) print dialog cannot be prevented from being shown in IE11. event.preventDefault(); if (event.stopImmediatePropagation) { event.stopImmediatePropagation(); @@ -294,16 +289,6 @@ window.addEventListener('keydown', function(event) { } } }, true); -if (hasAttachEvent) { - // eslint-disable-next-line consistent-return - document.attachEvent('onkeydown', function(event) { - event = event || window.event; - if (event.keyCode === /* P= */ 80 && event.ctrlKey) { - event.keyCode = 0; - return false; - } - }); -} if ('onbeforeprint' in window) { // Do not propagate before/afterprint events when they are not triggered