From e027178356e1113174527afa2cbca86ad92029b8 Mon Sep 17 00:00:00 2001 From: Jonas Jenwald Date: Sat, 4 Dec 2021 16:48:15 +0100 Subject: [PATCH] Tweak the "pagesloaded" event handler in `PDFOutlineViewer` These changes improves the consistency ever so slightly in the `PDFOutlineViewer._dispatchEvent` method, by making sure that we can tell the following two cases apart: - The "pagesloaded" event has *not yet* been fired. - The "pagesloaded" event has been fired, but no pages were available. --- web/pdf_outline_viewer.js | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/web/pdf_outline_viewer.js b/web/pdf_outline_viewer.js index 70feaa58a..fd03829f7 100644 --- a/web/pdf_outline_viewer.js +++ b/web/pdf_outline_viewer.js @@ -72,7 +72,7 @@ class PDFOutlineViewer extends BaseTreeViewer { this._pageNumberToDestHashCapability = null; this._currentPageNumber = 1; - this._isPagesLoaded = false; + this._isPagesLoaded = null; if ( this._currentOutlineItemCapability && @@ -93,8 +93,10 @@ class PDFOutlineViewer extends BaseTreeViewer { this._pdfDocument?.loadingParams.disableAutoFetch ) { this._currentOutlineItemCapability.resolve(/* enabled = */ false); - } else if (this._isPagesLoaded) { - this._currentOutlineItemCapability.resolve(/* enabled = */ true); + } else if (this._isPagesLoaded !== null) { + this._currentOutlineItemCapability.resolve( + /* enabled = */ this._isPagesLoaded + ); } this.eventBus.dispatch("outlineloaded", {