Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove "else after return" from the getUrlProp/getDataProp helper functions

Browse Source 
This helps readability of this code a little bit, in my opinion, and it's actually ever so slightly less code in the *built* `pdf.js` file.
This commit is contained in:
Jonas Jenwald 2023-02-14 10:45:28 +01:00
parent 546902df63
commit df3b359280
1 changed files with 8 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/display/api.js
View File

@ -507,7 +507,8 @@ async function _fetchDocument(worker, source) {
function getUrlProp(val) { function getUrlProp(val) {
if (typeof PDFJSDev !== "undefined" && PDFJSDev.test("MOZCENTRAL")) { if (typeof PDFJSDev !== "undefined" && PDFJSDev.test("MOZCENTRAL")) {
return null; // The 'url' is unused with `PDFDataRangeTransport`. return null; // The 'url' is unused with `PDFDataRangeTransport`.
} else if (val instanceof URL) { }
if (val instanceof URL) {
return val.href; return val.href;
} }
try { try {
@ -539,20 +540,17 @@ function getDataProp(val) {
val instanceof Buffer // eslint-disable-line no-undef val instanceof Buffer // eslint-disable-line no-undef
) { ) {
return new Uint8Array(val); return new Uint8Array(val);
} else if ( }
val instanceof Uint8Array && if (val instanceof Uint8Array && val.byteLength === val.buffer.byteLength) {
val.byteLength === val.buffer.byteLength
) {
// Use the data as-is when it's already a Uint8Array that completely // Use the data as-is when it's already a Uint8Array that completely
// "utilizes" its underlying ArrayBuffer, to prevent any possible // "utilizes" its underlying ArrayBuffer, to prevent any possible
// issues when transferring it to the worker-thread. // issues when transferring it to the worker-thread.
return val; return val;
} else if (typeof val === "string") { }
if (typeof val === "string") {
return stringToBytes(val); return stringToBytes(val);
} else if ( }
(typeof val === "object" && !isNaN(val?.length)) || if ((typeof val === "object" && !isNaN(val?.length)) || isArrayBuffer(val)) {
isArrayBuffer(val)
) {
return new Uint8Array(val); return new Uint8Array(val);
} }
throw new Error( throw new Error(