From de932573ddc36ae5525f195f5425941fc4dfd087 Mon Sep 17 00:00:00 2001
From: Jonas Jenwald <jonas.jenwald@gmail.com>
Date: Thu, 27 Aug 2020 15:50:55 +0200
Subject: [PATCH] Revert "Use a link, rather than `window.open`, when opening
 PDF attachments in Firefox (bug 1661259)"

This reverts commit 1e5d4b6a8025477c3b15b3a320b1cc41ccd7c2bc, since it unfortunately doesn't work in all situations.

Please note that I did *successfully* test the patch in a local Firefox build, obviously with an ad blocker installed.
However, I've now tested the *latest* Nightly-build with my default profile, and unfortunately I can still reproduce the bug there!?
---
 web/pdf_attachment_viewer.js | 17 +----------------
 1 file changed, 1 insertion(+), 16 deletions(-)

diff --git a/web/pdf_attachment_viewer.js b/web/pdf_attachment_viewer.js
index a6406a053..0543cd6c5 100644
--- a/web/pdf_attachment_viewer.js
+++ b/web/pdf_attachment_viewer.js
@@ -118,22 +118,7 @@ class PDFAttachmentViewer extends BaseTreeViewer {
           encodeURIComponent(blobUrl + "#" + filename);
       }
       try {
-        if (typeof PDFJSDev === "undefined" || !PDFJSDev.test("MOZCENTRAL")) {
-          window.open(viewerUrl);
-        } else {
-          // Since we have a full URL in the MOZCENTRAL-build, use a link rather
-          // than `window.open` since e.g. ad blockers may otherwise force-close
-          // the newly opened window and thus break viewing of PDF attachments
-          // (fixes bug 1661259).
-          const a = document.createElement("a");
-          a.hidden = true;
-          a.href = viewerUrl;
-          a.target = "_blank";
-          // <a> must be in the document, otherwise `a.click()` is ignored.
-          (document.body || document.documentElement).appendChild(a);
-          a.click();
-          a.remove();
-        }
+        window.open(viewerUrl);
       } catch (ex) {
         console.error(`_bindPdfLink: ${ex}`);
         // Release the `blobUrl`, since opening it failed...