Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use const in preferences.js

Browse Source
This commit is contained in:
Wojciech Maj 2019-12-22 18:21:04 +01:00
parent 6316b2a195
commit de6982e58e
No known key found for this signature in database
GPG Key ID: 24A586806A31F908
1 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
web/preferences.js
View File

@ -12,6 +12,7 @@
* See the License for the specific language governing permissions and * See the License for the specific language governing permissions and
* limitations under the License. * limitations under the License.
*/ */
/* eslint no-var: error, prefer-const: error */
let defaultPreferences = null; let defaultPreferences = null;
function getDefaultPreferences() { function getDefaultPreferences() {
@ -60,7 +61,7 @@ class BasePreferences {
if (!prefs) { if (!prefs) {
return; return;
} }
for (let name in prefs) { for (const name in prefs) {
const defaultValue = this.defaults[name], prefValue = prefs[name]; const defaultValue = this.defaults[name], prefValue = prefs[name];
// Ignore preferences not present in, or whose types don't match, // Ignore preferences not present in, or whose types don't match,
// the default values. // the default values.
@ -113,15 +114,15 @@ class BasePreferences {
*/ */
async set(name, value) { async set(name, value) {
await this._initializedPromise; await this._initializedPromise;
let defaultValue = this.defaults[name]; const defaultValue = this.defaults[name];
if (defaultValue === undefined) { if (defaultValue === undefined) {
throw new Error(`Set preference: "${name}" is undefined.`); throw new Error(`Set preference: "${name}" is undefined.`);
} else if (value === undefined) { } else if (value === undefined) {
throw new Error('Set preference: no value is specified.'); throw new Error('Set preference: no value is specified.');
} }
let valueType = typeof value; const valueType = typeof value;
let defaultType = typeof defaultValue; const defaultType = typeof defaultValue;
if (valueType !== defaultType) { if (valueType !== defaultType) {
if (valueType === 'number' && defaultType === 'string') { if (valueType === 'number' && defaultType === 'string') {
@ -147,12 +148,12 @@ class BasePreferences {
*/ */
async get(name) { async get(name) {
await this._initializedPromise; await this._initializedPromise;
let defaultValue = this.defaults[name]; const defaultValue = this.defaults[name];
if (defaultValue === undefined) { if (defaultValue === undefined) {
throw new Error(`Get preference: "${name}" is undefined.`); throw new Error(`Get preference: "${name}" is undefined.`);
} else { } else {
let prefValue = this.prefs[name]; const prefValue = this.prefs[name];
if (prefValue !== undefined) { if (prefValue !== undefined) {
return prefValue; return prefValue;