Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use the page.$eval method in the bug1844576 integration test

Browse Source 
We already use `page.$eval` in most other integration tests and it's
simpler because it already takes the selector as argument, so we don't
have to do a separate `querySelector` call ourselves.
This commit is contained in:
Tim van der Meij 2023-09-17 12:55:13 +02:00
parent 518590ac7d
commit dd46110f6b
No known key found for this signature in database
GPG Key ID: 8C3FD2925A5F2762
1 changed files with 16 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

42
test/integration/scripting_spec.js
View File

@ -1996,45 +1996,35 @@ describe("Interaction", () => {
it("must check that a field has the correct formatted value", async () => {
await Promise.all(
pages.map(async ([browserName, page]) => {
const hasVisibleCanvas = await page.evaluate(_ => {
const elem = document.querySelector(
`[data-annotation-id="9R"] > canvas`
);
return elem && !elem.hasAttribute("hidden");
});
const hasVisibleCanvas = await page.$eval(
`[data-annotation-id="9R"] > canvas`,
elem => elem && !elem.hasAttribute("hidden")
);
expect(hasVisibleCanvas)
.withContext(`In ${browserName}`)
.toEqual(true);
const hasHiddenInput = await page.evaluate(_ => {
const elem = document.querySelector(
`[data-annotation-id="9R"] > input`
);
return elem?.hasAttribute("hidden");
});
const hasHiddenInput = await page.$eval(
`[data-annotation-id="9R"] > input`,
elem => elem?.hasAttribute("hidden")
);
expect(hasHiddenInput).withContext(`In ${browserName}`).toEqual(true);
await page.click(getSelector("12R"));
await page.waitForTimeout(10);
const hasHiddenCanvas = await page.evaluate(_ => {
const elem = document.querySelector(
`[data-annotation-id="9R"] > canvas`
);
return elem?.hasAttribute("hidden");
});
const hasHiddenCanvas = await page.$eval(
`[data-annotation-id="9R"] > canvas`,
elem => elem?.hasAttribute("hidden")
);
expect(hasHiddenCanvas)
.withContext(`In ${browserName}`)
.toEqual(true);
const hasVisibleInput = await page.evaluate(_ => {
const elem = document.querySelector(
`[data-annotation-id="9R"] > input`
);
return elem && !elem.hasAttribute("hidden");
});
const hasVisibleInput = await page.$eval(
`[data-annotation-id="9R"] > input`,
elem => elem && !elem.hasAttribute("hidden")
);
expect(hasVisibleInput)
.withContext(`In ${browserName}`)
.toEqual(true);