Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

PDFScriptingManager: Bind mousedown listener with capture=true

Browse Source 
PDFScriptingManager uses the `mousedown` and `mouseup` listeners to keep
track of whether the mouse pointer is pressed in the `isDown` flag.
These listeners were registered to run during the bubbling phase of the
event dispatch, which can be interrupted if any of the previous event
listeners stopped the event propagation. An example of that is by
`GrabToPan` in web/grab_to_pan.js.

Since the mousedown (and mouseup) listeners of PDFScriptingManager are
free of side effects, and the intention is to always run them, it makes
most sense to register them with the capture flag.
This commit is contained in:
Rob Wu 2022-03-28 02:34:00 +02:00
parent 0dd6bc9a85
commit dc6e2ed6f8
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
web/pdf_scripting_manager.js
View File

@ -154,7 +154,7 @@ class PDFScriptingManager {
this._eventBus._on(name, listener);
}
for (const [name, listener] of this._domEvents) {
window.addEventListener(name, listener);
window.addEventListener(name, listener, true);
}
try {
@ -507,7 +507,7 @@ class PDFScriptingManager {
this._internalEvents.clear();
for (const [name, listener] of this._domEvents) {
window.removeEventListener(name, listener);
window.removeEventListener(name, listener, true);
}
this._domEvents.clear();