Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #13976 from Snuffleupagus/_textDivProperties-cleanup

Browse Source 
Reduce the size of `TextLayerRenderTask._textDivProperties` in "regular" text-selection mode
This commit is contained in:
Tim van der Meij 2021-09-05 14:45:17 +02:00 committed by GitHub
commit d95f680d66
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 29 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

43
src/display/text_layer.js
View File

@ -118,18 +118,25 @@ function getAscent(fontFamily, ctx) {
function appendText(task, geom, styles, ctx) { function appendText(task, geom, styles, ctx) {
// Initialize all used properties to keep the caches monomorphic. // Initialize all used properties to keep the caches monomorphic.
const textDiv = document.createElement("span"); const textDiv = document.createElement("span");
const textDivProperties = { const textDivProperties = task._enhanceTextSelection
angle: 0, ? {
canvasWidth: 0, angle: 0,
hasText: geom.str !== "", canvasWidth: 0,
hasEOL: geom.hasEOL, hasText: geom.str !== "",
originalTransform: null, hasEOL: geom.hasEOL,
paddingBottom: 0, originalTransform: null,
paddingLeft: 0, paddingBottom: 0,
paddingRight: 0, paddingLeft: 0,
paddingTop: 0, paddingRight: 0,
scale: 1, paddingTop: 0,
}; scale: 1,
}
: {
angle: 0,
canvasWidth: 0,
hasText: geom.str !== "",
hasEOL: geom.hasEOL,
};
task._textDivs.push(textDiv); task._textDivs.push(textDiv);
@ -588,6 +595,11 @@ class TextLayerRenderTask {
// Always clean-up the temporary canvas once rendering is no longer pending. // Always clean-up the temporary canvas once rendering is no longer pending.
this._capability.promise this._capability.promise
.finally(() => { .finally(() => {
if (!this._enhanceTextSelection) {
// The `textDiv` properties are no longer needed.
this._textDivProperties = null;
}
if (this._layoutTextCtx) { if (this._layoutTextCtx) {
// Zeroing the width and height cause Firefox to release graphics // Zeroing the width and height cause Firefox to release graphics
// resources immediately, which can greatly reduce memory consumption. // resources immediately, which can greatly reduce memory consumption.
@ -679,8 +691,11 @@ class TextLayerRenderTask {
const { width } = this._layoutTextCtx.measureText(textDiv.textContent); const { width } = this._layoutTextCtx.measureText(textDiv.textContent);
if (width > 0) { if (width > 0) {
textDivProperties.scale = textDivProperties.canvasWidth / width; const scale = textDivProperties.canvasWidth / width;
transform = `scaleX(${textDivProperties.scale})`; if (this._enhanceTextSelection) {
textDivProperties.scale = scale;
}
transform = `scaleX(${scale})`;
} }
} }
if (textDivProperties.angle !== 0) { if (textDivProperties.angle !== 0) {