Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Ensure that printing, triggered from scripting, won't accidentally throw in PDFScriptingManager._updateFromSandbox (#13104)

Browse Source 
The issue that this patch fixes is extremely unlikely, but still theoretically possible, and I really should've caught this earlier.
Note how `BaseViewer.pagesPromise` will only be defined when a document is active, see below, and that if a printing event (triggered from scripting) arrives while the document is been closed there's a small chance that the promise isn't defined.

eb92ed12f2/web/base_viewer.js (L426-L428)
This commit is contained in:
Jonas Jenwald 2021-03-16 14:22:39 +01:00 committed by GitHub
parent dd3797a325
commit d92b77e87f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
web/pdf_scripting_manager.js
View File

@ -260,7 +260,7 @@ class PDFScriptingManager {
/** /**
* @private * @private
*/ */
_updateFromSandbox(detail) { async _updateFromSandbox(detail) {
const { id, command, value } = detail; const { id, command, value } = detail;
if (!id) { if (!id) {
switch (command) { switch (command) {
@ -277,9 +277,8 @@ class PDFScriptingManager {
this._pdfViewer.currentPageNumber = value + 1; this._pdfViewer.currentPageNumber = value + 1;
break; break;
case "print": case "print":
this._pdfViewer.pagesPromise.then(() => { await this._pdfViewer.pagesPromise;
this._eventBus.dispatch("print", { source: this }); this._eventBus.dispatch("print", { source: this });
});
break; break;
case "println": case "println":
console.log(value); console.log(value);