From d8c2bcc93a5e8934ca647652cecc03ca2b064b48 Mon Sep 17 00:00:00 2001
From: Jonas Jenwald <jonas.jenwald@gmail.com>
Date: Sun, 8 Jul 2018 10:56:06 +0200
Subject: [PATCH] Temporarily disable the Spread mode buttons when horizontal
scrolling is enabled
Given that the non-default Spread modes (currently) doesn't affect the page layout when horizontal scrolling is enabled, having the Spread buttons appear active when clicking them appears to do *nothing* is probably confusing rather than helpful to users.
---
web/secondary_toolbar.js | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/web/secondary_toolbar.js b/web/secondary_toolbar.js
index 3eaabf9c1..bb41f2068 100644
--- a/web/secondary_toolbar.js
+++ b/web/secondary_toolbar.js
@@ -221,6 +221,13 @@ class SecondaryToolbar {
buttons.scrollWrappedButton.classList.add('toggled');
break;
}
+
+ // Temporarily *disable* the Spread buttons when horizontal scrolling is
+ // enabled, since the non-default Spread modes doesn't affect the layout.
+ const isScrollModeHorizontal = (evt.mode === ScrollMode.HORIZONTAL);
+ buttons.spreadNoneButton.disabled = isScrollModeHorizontal;
+ buttons.spreadOddButton.disabled = isScrollModeHorizontal;
+ buttons.spreadEvenButton.disabled = isScrollModeHorizontal;
}
this.eventBus.on('scrollmodechanged', scrollModeChanged);