From 39cf4a00085aff687aa8541beea107ae2fc94646 Mon Sep 17 00:00:00 2001 From: Jonas Jenwald Date: Sun, 28 Feb 2021 13:11:22 +0100 Subject: [PATCH] Don't warn about actions that require scripting support in `Catalog.parseDestDictionary` Now that we have scripting support, warning about e.g. JavaScript actions doesn't seem necessary anymore. Especially considering that scripting-related actions are/will not be parsed by the `Catalog.parseDestDictionary` method anyway, since it's intended for handling "simple" actions. --- src/core/obj.js | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/src/core/obj.js b/src/core/obj.js index 3d4226d79..10f61c90a 100644 --- a/src/core/obj.js +++ b/src/core/obj.js @@ -1366,7 +1366,16 @@ class Catalog { } /* falls through */ default: - warn(`parseDestDictionary: unsupported action type "${actionName}".`); + if ( + actionName === "JavaScript" || + actionName === "ResetForm" || + actionName === "SubmitForm" + ) { + // Don't bother the user with a warning for actions that require + // scripting support, since those will be handled separately. + break; + } + warn(`parseDestDictionary - unsupported action: "${actionName}".`); break; } } else if (destDict.has("Dest")) {