Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove a superfluous linkService.isPageVisible check from PDFFindController (PR 10217 follow-up)

Browse Source 
Unless the `PDFLinkService` instance contains all of the expected methods, a lot of things will break in various places in the default viewer. Hence there's not much value in having this check, and outright falling seems more appropriate.

Finally, this also makes the return value explicit in this case, since that's consistent with the rest of the `PDFFindController._shouldDirtyMatch` method.
This commit is contained in:
Jonas Jenwald 2019-06-10 17:11:21 +02:00
parent 06b253d609
commit d6cc393cd9
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
web/pdf_find_controller.js
View File

@ -252,9 +252,9 @@ class PDFFindController {
// over matches at the top/bottom of pages thus making them completely // over matches at the top/bottom of pages thus making them completely
// inaccessible when there's multiple pages visible in the viewer. // inaccessible when there's multiple pages visible in the viewer.
if (pageNumber >= 1 && pageNumber <= linkService.pagesCount && if (pageNumber >= 1 && pageNumber <= linkService.pagesCount &&
linkService.page !== pageNumber && linkService.isPageVisible && pageNumber !== linkService.page &&
!linkService.isPageVisible(pageNumber)) { !linkService.isPageVisible(pageNumber)) {
break; return true;
} }
return false; return false;
case 'findhighlightallchange': case 'findhighlightallchange':