From d476186b9f8bd7178e2eb2436d1e6456f63eea72 Mon Sep 17 00:00:00 2001 From: Jonas Jenwald Date: Wed, 19 Jan 2022 12:02:05 +0100 Subject: [PATCH] Temporarily disable the browser-tests in Google Chrome on the Windows bot Either the latest Chromium update, the latest Puppeteer update, or a combination of them both are now causing the Windows bot to timeout during the browser-tests. To unblock both the updates and other improvements (i.e. the `structuredClone` polyfill), let's simply disable the problematic configuration for now since this a Mozilla project after all. --- gulpfile.js | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/gulpfile.js b/gulpfile.js index b0f38b90d..2f6b96154 100644 --- a/gulpfile.js +++ b/gulpfile.js @@ -555,11 +555,19 @@ function createTestSource(testsName, { bot = false, xfaOnly = false } = {}) { console.log("### Running " + testsName + " tests"); const PDF_TEST = process.env.PDF_TEST || "test_manifest.json"; + let forceNoChrome = false; const args = ["test.js"]; switch (testsName) { case "browser": if (!bot) { args.push("--reftest"); + } else { + const os = process.env.OS; + if (/windows/i.test(os)) { + // The browser-tests are too slow in Google Chrome on the Windows + // bot, causing a timeout, hence disabling them for now. + forceNoChrome = true; + } } if (xfaOnly) { args.push("--xfaOnly"); @@ -582,7 +590,7 @@ function createTestSource(testsName, { bot = false, xfaOnly = false } = {}) { if (bot) { args.push("--strictVerify"); } - if (process.argv.includes("--noChrome")) { + if (process.argv.includes("--noChrome") || forceNoChrome) { args.push("--noChrome"); }