From d3cb5e7117fbd112b90fb79e92dba630fdb79f29 Mon Sep 17 00:00:00 2001 From: Jonas Jenwald Date: Sat, 23 Jun 2018 10:30:22 +0200 Subject: [PATCH] Don't attempt to modify the DOM and/or trigger rendering when changing Scroll/Spread modes without a PDF document being loaded --- web/pdf_viewer.js | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/web/pdf_viewer.js b/web/pdf_viewer.js index 78a2ce3a5..6e42db779 100644 --- a/web/pdf_viewer.js +++ b/web/pdf_viewer.js @@ -103,6 +103,9 @@ class PDFViewer extends BaseViewer { this.eventBus.dispatch('scrollmodechanged', { mode, }); this._updateScrollModeClasses(); + if (!this.pdfDocument) { + return; + } const pageNumber = this._currentPageNumber; // Non-numeric scale modes can be sensitive to the scroll orientation. // Call this before re-scrolling to the current page, to ensure that any @@ -140,6 +143,9 @@ class PDFViewer extends BaseViewer { } _regroupSpreads() { + if (!this.pdfDocument) { + return; + } const viewer = this.viewer, pages = this._pages; // Temporarily remove all the pages from the DOM. viewer.textContent = '';