Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove unnecessary checks from the PDFDocumentProperties constructor

Browse Source 
Given that none of the relevant options are marked as optional in the code/JSDocs, and that the `PDFDocumentProperties` class is specific to the default viewer (and not exposed as part of the viewer components), there's no good reason as far as I can tell for these checks.
This commit is contained in:
Jonas Jenwald 2020-03-22 15:46:50 +01:00
parent 3cebb430c2
commit d3044ac394
1 changed files with 8 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
web/pdf_document_properties.js
View File

@ -72,25 +72,21 @@ class PDFDocumentProperties {
this.l10n = l10n; this.l10n = l10n;
this._reset(); this._reset();
// Bind the event listener for the Close button.
closeButton.addEventListener("click", this.close.bind(this));
if (closeButton) {
// Bind the event listener for the Close button.
closeButton.addEventListener("click", this.close.bind(this));
}
this.overlayManager.register( this.overlayManager.register(
this.overlayName, this.overlayName,
this.container, this.container,
this.close.bind(this) this.close.bind(this)
); );
if (eventBus) { eventBus._on("pagechanging", evt => {
eventBus._on("pagechanging", evt => { this._currentPageNumber = evt.pageNumber;
this._currentPageNumber = evt.pageNumber; });
}); eventBus._on("rotationchanging", evt => {
eventBus._on("rotationchanging", evt => { this._pagesRotation = evt.pagesRotation;
this._pagesRotation = evt.pagesRotation; });
});
}
this._isNonMetricLocale = true; // The default viewer locale is 'en-us'. this._isNonMetricLocale = true; // The default viewer locale is 'en-us'.
l10n.getLanguage().then(locale => { l10n.getLanguage().then(locale => {