Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove the closure from the DeviceCmykCS class

Browse Source 
Now that modern JavaScript is fully supported also in the worker-thread we no longer need to keep old closures, which slightly reduces the size of the code.
This commit is contained in:
Jonas Jenwald 2023-09-15 15:53:05 +02:00
parent 586d3add46
commit d2c8997380
1 changed files with 30 additions and 34 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/core/colorspace.js
View File

@ -781,14 +781,18 @@ class DeviceRgbCS extends ColorSpace {
/** /**
* The default color is `new Float32Array([0, 0, 0, 1])`. * The default color is `new Float32Array([0, 0, 0, 1])`.
*/ */
const DeviceCmykCS = (function DeviceCmykCSClosure() { class DeviceCmykCS extends ColorSpace {
constructor() {
super("DeviceCMYK", 4);
}
// The coefficients below was found using numerical analysis: the method of // The coefficients below was found using numerical analysis: the method of
// steepest descent for the sum((f_i - color_value_i)^2) for r/g/b colors, // steepest descent for the sum((f_i - color_value_i)^2) for r/g/b colors,
// where color_value is the tabular value from the table of sampled RGB colors // where color_value is the tabular value from the table of sampled RGB colors
// from CMYK US Web Coated (SWOP) colorspace, and f_i is the corresponding // from CMYK US Web Coated (SWOP) colorspace, and f_i is the corresponding
// CMYK color conversion using the estimation below: // CMYK color conversion using the estimation below:
// f(A, B,.. N) = Acc+Bcm+Ccy+Dck+c+Fmm+Gmy+Hmk+Im+Jyy+Kyk+Ly+Mkk+Nk+255 // f(A, B,.. N) = Acc+Bcm+Ccy+Dck+c+Fmm+Gmy+Hmk+Im+Jyy+Kyk+Ly+Mkk+Nk+255
function convertToRgb(src, srcOffset, srcScale, dest, destOffset) { #toRgb(src, srcOffset, srcScale, dest, destOffset) {
const c = src[srcOffset] * srcScale; const c = src[srcOffset] * srcScale;
const m = src[srcOffset + 1] * srcScale; const m = src[srcOffset + 1] * srcScale;
const y = src[srcOffset + 2] * srcScale; const y = src[srcOffset + 2] * srcScale;
@ -847,12 +851,6 @@ const DeviceCmykCS = (function DeviceCmykCSClosure() {
k * (-22.33816807309886 * k - 180.12613974708367); k * (-22.33816807309886 * k - 180.12613974708367);
} }
// eslint-disable-next-line no-shadow
class DeviceCmykCS extends ColorSpace {
constructor() {
super("DeviceCMYK", 4);
}
getRgbItem(src, srcOffset, dest, destOffset) { getRgbItem(src, srcOffset, dest, destOffset) {
if (typeof PDFJSDev === "undefined" || PDFJSDev.test("TESTING")) { if (typeof PDFJSDev === "undefined" || PDFJSDev.test("TESTING")) {
assert( assert(
@ -860,7 +858,7 @@ const DeviceCmykCS = (function DeviceCmykCSClosure() {
'DeviceCmykCS.getRgbItem: Unsupported "dest" type.' 'DeviceCmykCS.getRgbItem: Unsupported "dest" type.'
); );
} }
convertToRgb(src, srcOffset, 1, dest, destOffset); this.#toRgb(src, srcOffset, 1, dest, destOffset);
} }
getRgbBuffer(src, srcOffset, count, dest, destOffset, bits, alpha01) { getRgbBuffer(src, srcOffset, count, dest, destOffset, bits, alpha01) {
@ -872,7 +870,7 @@ const DeviceCmykCS = (function DeviceCmykCSClosure() {
} }
const scale = 1 / ((1 << bits) - 1); const scale = 1 / ((1 << bits) - 1);
for (let i = 0; i < count; i++) { for (let i = 0; i < count; i++) {
convertToRgb(src, srcOffset, scale, dest, destOffset); this.#toRgb(src, srcOffset, scale, dest, destOffset);
srcOffset += 4; srcOffset += 4;
destOffset += 3 + alpha01; destOffset += 3 + alpha01;
} }
@ -882,8 +880,6 @@ const DeviceCmykCS = (function DeviceCmykCSClosure() {
return ((inputLength / 4) * (3 + alpha01)) | 0; return ((inputLength / 4) * (3 + alpha01)) | 0;
} }
} }
return DeviceCmykCS;
})();
/** /**
* CalGrayCS: Based on "PDF Reference, Sixth Ed", p.245 * CalGrayCS: Based on "PDF Reference, Sixth Ed", p.245