From 3a824f69d4395c50bbc8fdd0d5178a62c37a688c Mon Sep 17 00:00:00 2001 From: Brendan Dahl Date: Tue, 21 Feb 2012 13:37:22 -0800 Subject: [PATCH 1/2] Fix the stepper beyond page 1. --- web/debugger.js | 24 +++++++++++++++--------- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/web/debugger.js b/web/debugger.js index c759a5ee8..aee0c3c77 100644 --- a/web/debugger.js +++ b/web/debugger.js @@ -180,7 +180,7 @@ var StepperManager = (function StepperManagerClosure() { this.selectStepper(pageNumber, false); return stepper; }, - selectStepper: function selectStepper(pageNumber, selectPanel) { + selectStepper: function selectStepper(pageNumber, selectPanel, change) { if (selectPanel) this.manager.selectPanel(1); for (var i = 0; i < steppers.length; ++i) { @@ -190,6 +190,11 @@ var StepperManager = (function StepperManagerClosure() { else stepper.panel.setAttribute('hidden', true); } + var options = stepperChooser.options; + for (var i = 0; i < options.length; ++i) { + var option = options[i]; + option.selected = option.value == pageNumber; + } }, saveBreakPoints: function saveBreakPoints(pageNumber, bps) { breakPoints[pageNumber] = bps; @@ -234,7 +239,7 @@ var Stepper = (function StepperClosure() { for (var i = 0; i < IRQueue.fnArray.length; i++) { var line = c('tr'); line.className = 'line'; - line.id = 'idx' + i; + line.dataset.idx = i; table.appendChild(line); var checked = this.breakPoints.indexOf(i) != -1; var args = IRQueue.argsArray[i] ? IRQueue.argsArray[i] : []; @@ -299,13 +304,14 @@ var Stepper = (function StepperClosure() { }, goTo: function goTo(idx) { var allRows = this.panel.getElementsByClassName('line'); - for (var x = 0; x < allRows.length; x++) { - allRows[x].style.backgroundColor = null; - } - var row = document.getElementById('idx' + idx); - if (row) { - row.style.backgroundColor = 'rgb(251,250,207)'; - row.scrollIntoView(); + for (var x = 0, xx = allRows.length; x < xx; ++x) { + var row = allRows[x]; + if (row.dataset.idx == idx) { + row.style.backgroundColor = 'rgb(251,250,207)'; + row.scrollIntoView(); + } else { + row.style.backgroundColor = null; + } } } }; From 4b887fe1c205a6a9d16cc9b77f96e640df6c8b60 Mon Sep 17 00:00:00 2001 From: Brendan Dahl Date: Tue, 21 Feb 2012 13:39:04 -0800 Subject: [PATCH 2/2] Remove unused variable. --- web/debugger.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/web/debugger.js b/web/debugger.js index aee0c3c77..43407fdaa 100644 --- a/web/debugger.js +++ b/web/debugger.js @@ -180,7 +180,7 @@ var StepperManager = (function StepperManagerClosure() { this.selectStepper(pageNumber, false); return stepper; }, - selectStepper: function selectStepper(pageNumber, selectPanel, change) { + selectStepper: function selectStepper(pageNumber, selectPanel) { if (selectPanel) this.manager.selectPanel(1); for (var i = 0; i < steppers.length; ++i) {