Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Ensure that the loadingIconDiv is always visible (PR 15829 follow-up)

Browse Source 
After the changes in PR 15829 the `loadingIconDiv` is no longer always visible when it should be, specifically in the case where we cancel and re-render a partially parsed/rendered page.
To reproduce this, try opening https://github.com/mozilla/pdf.js/files/1522715/wuppertal_2012.pdf in the viewer and change the zoom level while rendering is ongoing. In this case the `loadingIconDiv` doesn't actually become visible, despite being present in the DOM, since it's no longer at the end of the page-div.

I don't know to what extent this renders PR 15829 "pointless", however we're not repeatedly re-creating and re-inserting the `loadingIconDiv` but rather just *move* the existing element in the DOM.
This commit is contained in:
Jonas Jenwald 2022-12-22 12:24:18 +01:00
parent a749f6cc14
commit d042a3ca76
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
web/pdf_page_view.js
View File

@ -490,6 +490,7 @@ class PDFPageView {
div.append(this.loadingIconDiv);
} else {
this.toggleLoadingIconSpinner();
div.append(this.loadingIconDiv);
}
if (