Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove unused parameters from the onOpenWithTransport method in PDFViewerApplication.initPassiveLoading

Browse Source 
The only parameter that we actually need here is the `PDFDataRangeTransport`-instance, since the others are not necessary.
 - The `url` parameter, as passed to the `getDocument` function in the API, is simply being ignored; see 2d87a2eb1c/src/display/api.js (L447-L458)
 - The `length` parameter, as passed to the `getDocument` function in the API, is always being overwritten; see 2d87a2eb1c/src/display/api.js (L519-L525)
This commit is contained in:
Jonas Jenwald 2023-01-31 21:34:42 +01:00
parent 2d87a2eb1c
commit cf8ee47589
3 changed files with 27 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/display/api.js
View File

@ -283,6 +283,9 @@ function getDocument(src) {
switch (key) { switch (key) {
case "url": case "url":
if (typeof PDFJSDev !== "undefined" && PDFJSDev.test("MOZCENTRAL")) {
continue; // The 'url' is unused with `PDFDataRangeTransport`.
} else {
if (val instanceof URL) { if (val instanceof URL) {
params[key] = val.href; params[key] = val.href;
continue; continue;
@ -305,6 +308,7 @@ function getDocument(src) {
"Invalid PDF url data: " + "Invalid PDF url data: " +
"either string or URL-object is expected in the url property." "either string or URL-object is expected in the url property."
); );
}
case "range": case "range":
rangeTransport = val; rangeTransport = val;
continue; continue;

4
web/app.js
View File

@ -745,8 +745,8 @@ const PDFViewerApplication = {
throw new Error("Not implemented: initPassiveLoading"); throw new Error("Not implemented: initPassiveLoading");
} }
this.externalServices.initPassiveLoading({ this.externalServices.initPassiveLoading({
onOpenWithTransport: (url, length, transport) => { onOpenWithTransport: range => {
this.open({ url, length, range: transport }); this.open({ range });
}, },
onOpenWithData: (data, contentDispositionFilename) => { onOpenWithData: (data, contentDispositionFilename) => {
if (isPdfFile(contentDispositionFilename)) { if (isPdfFile(contentDispositionFilename)) {

6
web/firefoxcom.js
View File

@ -347,11 +347,7 @@ class FirefoxExternalServices extends DefaultExternalServices {
args.filename args.filename
); );
callbacks.onOpenWithTransport( callbacks.onOpenWithTransport(pdfDataRangeTransport);
args.pdfUrl,
args.length,
pdfDataRangeTransport
);
break; break;
case "range": case "range":
pdfDataRangeTransport.onDataRange(args.begin, args.chunk); pdfDataRangeTransport.onDataRange(args.begin, args.chunk);