Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove the data-pdfjsprinting attribute on the <body> when destroying FirefoxPrintService/PDFPrintService instances (issue 10948)

Browse Source 
Also, cleans up variable definitions slightly in the `FirefoxPrintService.layout` method.
This commit is contained in:
Jonas Jenwald 2019-07-10 16:49:31 +02:00
parent d7afb74a6e
commit cd48f05597
2 changed files with 13 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
web/firefox_print_service.js
View File

@ -77,18 +77,21 @@ function FirefoxPrintService(pdfDocument, pagesOverview, printContainer) {
FirefoxPrintService.prototype = {
layout() {
let pdfDocument = this.pdfDocument;
let printContainer = this.printContainer;
let body = document.querySelector('body');
const { pdfDocument, pagesOverview, printContainer, } = this;
const body = document.querySelector('body');
body.setAttribute('data-pdfjsprinting', true);
for (let i = 0, ii = this.pagesOverview.length; i < ii; ++i) {
composePage(pdfDocument, i + 1, this.pagesOverview[i], printContainer);
for (let i = 0, ii = pagesOverview.length; i < ii; ++i) {
composePage(pdfDocument, i + 1, pagesOverview[i], printContainer);
}
},
destroy() {
this.printContainer.textContent = '';
const body = document.querySelector('body');
body.removeAttribute('data-pdfjsprinting');
},
};

6
web/pdf_print_service.js
View File

@ -74,7 +74,7 @@ PDFPrintService.prototype = {
layout() {
this.throwIfInactive();
let body = document.querySelector('body');
const body = document.querySelector('body');
body.setAttribute('data-pdfjsprinting', true);
let hasEqualPageSizes = this.pagesOverview.every(function(size) {
@ -114,6 +114,10 @@ PDFPrintService.prototype = {
return;
}
this.printContainer.textContent = '';
const body = document.querySelector('body');
body.removeAttribute('data-pdfjsprinting');
if (this.pageStyleSheet) {
this.pageStyleSheet.remove();
this.pageStyleSheet = null;