Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add an AppOptions.setAll method, and use it in PDFViewerApplication._readPreferences

Browse Source 
Given that it's generally faster to call *one* function and have it loop through an object, rather than looping through an object and calling a function for every iteration, this patch will reduce the total time spent in `PDFViewerApplication._readPreferences` ever so slightly.
Also, over time we've been adding more and more preferences, rather than removing them, so using the new `AppOptions.setAll` method should be generally beneficial as well.

While the effect of these changes is quite small, it does reduces the time it takes for the preferences to be fully initialized. Given the amount of asynchronous code during viewer initialization, every bit of time that we can save should thus help.
Especially considering the recently added `viewerCssTheme` preference, which needs to be read very early to reduce the risk of the viewer UI "flashing" visibly as the theme changes, I figured that a couple of small patches reducing the time spend reading preferences cannot hurt.
This commit is contained in:
Jonas Jenwald 2020-11-17 13:44:15 +01:00
parent 4886a7cf69
commit cc861c34e9
2 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
web/app.js
View File

@ -305,12 +305,9 @@ const PDFViewerApplication = {
return;
}
try {
const prefs = await this.preferences.getAll();
for (const name in prefs) {
AppOptions.set(name, prefs[name]);
}
AppOptions.setAll(await this.preferences.getAll());
} catch (reason) {
console.error(`_readPreferences: "${reason.message}".`);
console.error(`_readPreferences: "${reason?.message}".`);
}
},

6
web/app_options.js
View File

@ -314,6 +314,12 @@ class AppOptions {
userOptions[name] = value;
}
static setAll(options) {
for (const name in options) {
userOptions[name] = options[name];
}
}
static remove(name) {
delete userOptions[name];
}