Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Move quadrilateral rendering logic into a method on the AnnotationElement class

Browse Source 
Doing so avoids some code duplication.
This commit is contained in:
Tim van der Meij 2020-12-05 19:32:13 +01:00
parent 0273080031
commit cb422a80b0
No known key found for this signature in database
GPG Key ID: 8C3FD2925A5F2762
1 changed files with 27 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

43
src/display/annotation_layer.js
View File

@ -23,6 +23,7 @@ import {
import {
AnnotationBorderStyleType,
AnnotationType,
assert,
stringToPDFString,
unreachable,
Util,
@ -324,6 +325,28 @@ class AnnotationElement {
container.appendChild(popup);
}
/**
* Render the quadrilaterals of the annotation.
*
* @private
* @param {string} className
* @memberof AnnotationElement
* @returns {Array<HTMLSectionElement>}
*/
_renderQuadrilaterals(className) {
if (
typeof PDFJSDev === "undefined" ||
PDFJSDev.test("!PRODUCTION || TESTING")
) {
assert(this.quadrilaterals, "Missing quadrilaterals during rendering");
}
this.quadrilaterals.forEach(quadrilateral => {
quadrilateral.className = className;
});
return this.quadrilaterals;
}
/**
* Render the annotation's HTML element in the empty container.
*
@ -1463,10 +1486,7 @@ class HighlightAnnotationElement extends AnnotationElement {
}
if (this.quadrilaterals) {
this.quadrilaterals.forEach(quadrilateral => {
quadrilateral.className = "highlightAnnotation";
});
return this.quadrilaterals;
return this._renderQuadrilaterals("highlightAnnotation");
}
this.container.className = "highlightAnnotation";
@ -1501,10 +1521,7 @@ class UnderlineAnnotationElement extends AnnotationElement {
}
if (this.quadrilaterals) {
this.quadrilaterals.forEach(quadrilateral => {
quadrilateral.className = "underlineAnnotation";
});
return this.quadrilaterals;
return this._renderQuadrilaterals("underlineAnnotation");
}
this.container.className = "underlineAnnotation";
@ -1539,10 +1556,7 @@ class SquigglyAnnotationElement extends AnnotationElement {
}
if (this.quadrilaterals) {
this.quadrilaterals.forEach(quadrilateral => {
quadrilateral.className = "squigglyAnnotation";
});
return this.quadrilaterals;
return this._renderQuadrilaterals("squigglyAnnotation");
}
this.container.className = "squigglyAnnotation";
@ -1577,10 +1591,7 @@ class StrikeOutAnnotationElement extends AnnotationElement {
}
if (this.quadrilaterals) {
this.quadrilaterals.forEach(quadrilateral => {
quadrilateral.className = "strikeoutAnnotation";
});
return this.quadrilaterals;
return this._renderQuadrilaterals("strikeoutAnnotation");
}
this.container.className = "strikeoutAnnotation";