Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #15567 from calixteman/bug1794717

Browse Source 
[Editor] Change the caret cursor into the arrow one only when a text editor isn't empty (bug 1794717)
This commit is contained in:
calixteman 2022-10-12 10:51:46 +02:00 committed by GitHub
commit c6cc7c6e6a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/display/editor/freetext.js
View File

@ -34,6 +34,8 @@ class FreeTextEditor extends AnnotationEditor {
#boundEditorDivFocus = this.editorDivFocus.bind(this); #boundEditorDivFocus = this.editorDivFocus.bind(this);
#boundEditorDivInput = this.editorDivInput.bind(this);
#boundEditorDivKeydown = this.editorDivKeydown.bind(this); #boundEditorDivKeydown = this.editorDivKeydown.bind(this);
#color; #color;
@ -230,7 +232,7 @@ class FreeTextEditor extends AnnotationEditor {
this.editorDiv.addEventListener("keydown", this.#boundEditorDivKeydown); this.editorDiv.addEventListener("keydown", this.#boundEditorDivKeydown);
this.editorDiv.addEventListener("focus", this.#boundEditorDivFocus); this.editorDiv.addEventListener("focus", this.#boundEditorDivFocus);
this.editorDiv.addEventListener("blur", this.#boundEditorDivBlur); this.editorDiv.addEventListener("blur", this.#boundEditorDivBlur);
this.parent.div.classList.remove("freeTextEditing"); this.editorDiv.addEventListener("input", this.#boundEditorDivInput);
} }
/** @inheritdoc */ /** @inheritdoc */
@ -248,6 +250,7 @@ class FreeTextEditor extends AnnotationEditor {
this.editorDiv.removeEventListener("keydown", this.#boundEditorDivKeydown); this.editorDiv.removeEventListener("keydown", this.#boundEditorDivKeydown);
this.editorDiv.removeEventListener("focus", this.#boundEditorDivFocus); this.editorDiv.removeEventListener("focus", this.#boundEditorDivFocus);
this.editorDiv.removeEventListener("blur", this.#boundEditorDivBlur); this.editorDiv.removeEventListener("blur", this.#boundEditorDivBlur);
this.editorDiv.removeEventListener("input", this.#boundEditorDivInput);
// On Chrome, the focus is given to <body> when contentEditable is set to // On Chrome, the focus is given to <body> when contentEditable is set to
// false, hence we focus the div. // false, hence we focus the div.
@ -374,6 +377,10 @@ class FreeTextEditor extends AnnotationEditor {
this.isEditing = false; this.isEditing = false;
} }
editorDivInput(event) {
this.parent.div.classList.toggle("freeTextEditing", this.isEmpty());
}
/** @inheritdoc */ /** @inheritdoc */
disableEditing() { disableEditing() {
this.editorDiv.setAttribute("role", "comment"); this.editorDiv.setAttribute("role", "comment");