Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #11432 from wojtekmaj/preferences-const

Browse Source 
Use const in perferences.js
This commit is contained in:
Tim van der Meij 2019-12-24 19:43:42 +01:00 committed by GitHub
commit c54bdab4aa
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
web/preferences.js
View File

@ -12,6 +12,7 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
/* eslint no-var: error, prefer-const: error */
let defaultPreferences = null;
function getDefaultPreferences() {
@ -60,7 +61,7 @@ class BasePreferences {
if (!prefs) {
return;
}
for (let name in prefs) {
for (const name in prefs) {
const defaultValue = this.defaults[name], prefValue = prefs[name];
// Ignore preferences not present in, or whose types don't match,
// the default values.
@ -113,15 +114,15 @@ class BasePreferences {
*/
async set(name, value) {
await this._initializedPromise;
let defaultValue = this.defaults[name];
const defaultValue = this.defaults[name];
if (defaultValue === undefined) {
throw new Error(`Set preference: "${name}" is undefined.`);
} else if (value === undefined) {
throw new Error('Set preference: no value is specified.');
}
let valueType = typeof value;
let defaultType = typeof defaultValue;
const valueType = typeof value;
const defaultType = typeof defaultValue;
if (valueType !== defaultType) {
if (valueType === 'number' && defaultType === 'string') {
@ -147,12 +148,12 @@ class BasePreferences {
*/
async get(name) {
await this._initializedPromise;
let defaultValue = this.defaults[name];
const defaultValue = this.defaults[name];
if (defaultValue === undefined) {
throw new Error(`Get preference: "${name}" is undefined.`);
} else {
let prefValue = this.prefs[name];
const prefValue = this.prefs[name];
if (prefValue !== undefined) {
return prefValue;