From c549069ebdac524de182eafef5bf0e5e5589a6fa Mon Sep 17 00:00:00 2001
From: Jonas Jenwald <jonas.jenwald@gmail.com>
Date: Sat, 5 Dec 2020 16:35:49 +0100
Subject: [PATCH] Replace the `testMode` parameter in `src/pdf.sandbox.js` with
 a constant, set using the pre-processor

This simplifies not just this code, but the unit-tests as well, and should be sufficient as far as I can tell.
Note also that currently, in the *built* `pdf.sandbox.js` file, there's even a line reading `testMode = testMode && false;` because of an accidentally flipped pre-processor statement.

Finally, in the `scripting_spec.js` unit-test, defines `sandboxBundleSrc` at the top of the file to make it easier to find and/or change it when necessary.
---
 src/pdf.sandbox.js          | 18 ++++++++----------
 test/unit/scripting_spec.js | 10 +++++-----
 2 files changed, 13 insertions(+), 15 deletions(-)

diff --git a/src/pdf.sandbox.js b/src/pdf.sandbox.js
index fe1f93dfc..9dec2bc5f 100644
--- a/src/pdf.sandbox.js
+++ b/src/pdf.sandbox.js
@@ -20,15 +20,17 @@ const pdfjsVersion = PDFJSDev.eval("BUNDLE_VERSION");
 /* eslint-disable-next-line no-unused-vars */
 const pdfjsBuild = PDFJSDev.eval("BUNDLE_BUILD");
 
+const TESTING =
+  typeof PDFJSDev === "undefined" || PDFJSDev.test("!PRODUCTION || TESTING");
+
 class Sandbox {
-  constructor(module, testMode) {
+  constructor(module) {
     this._evalInSandbox = module.cwrap("evalInSandbox", null, [
       "string",
       "int",
     ]);
     this._dispatchEventName = null;
     this._module = module;
-    this._testMode = testMode;
     this._alertOnError = 1;
   }
 
@@ -55,7 +57,7 @@ class Sandbox {
       "delete module;",
       "delete data;",
     ];
-    if (!this._testMode) {
+    if (!TESTING) {
       code = code.concat(extra.map(name => `delete ${name};`));
       code.push("delete debugMe;");
     }
@@ -86,7 +88,7 @@ class Sandbox {
   }
 
   evalForTesting(code, key) {
-    if (this._testMode) {
+    if (TESTING) {
       this._evalInSandbox(
         `try {
            send({ id: "${key}", result: ${code} });
@@ -99,13 +101,9 @@ class Sandbox {
   }
 }
 
-function QuickJSSandbox(testMode = false) {
-  testMode =
-    testMode &&
-    (typeof PDFJSDev === "undefined" ||
-      PDFJSDev.test("!PRODUCTION || TESTING"));
+function QuickJSSandbox() {
   return ModuleLoader().then(module => {
-    return new Sandbox(module, testMode);
+    return new Sandbox(module);
   });
 }
 
diff --git a/test/unit/scripting_spec.js b/test/unit/scripting_spec.js
index e4d6b1077..c8062b097 100644
--- a/test/unit/scripting_spec.js
+++ b/test/unit/scripting_spec.js
@@ -15,6 +15,8 @@
 
 import { loadScript } from "../../src/display/display_utils.js";
 
+const sandboxBundleSrc = "../../build/generic/build/pdf.sandbox.js";
+
 describe("Scripting", function () {
   let sandbox, send_queue, test_id, ref;
 
@@ -44,11 +46,9 @@ describe("Scripting", function () {
         send_queue.set(event.detail.id, event.detail);
       }
     };
-    const promise = loadScript("../../build/generic/build/pdf.sandbox.js").then(
-      () => {
-        return window.pdfjsSandbox.QuickJSSandbox(true);
-      }
-    );
+    const promise = loadScript(sandboxBundleSrc).then(() => {
+      return window.pdfjsSandbox.QuickJSSandbox();
+    });
     sandbox = {
       createSandbox(data) {
         promise.then(sbx => sbx.create(data));