Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Make stripCommentHeaders less greedy, to ensure that it doesn't eat 'use strict' directive at the top of files (PR 6627 follow-up)

Browse Source 
While browsing through the latest PDF.js update on mozilla-central, see https://hg.mozilla.org/integration/fx-team/rev/aef06cd725fc, I noticed that the `'use strict';` directives were missing at the top of a number of files.
This is fallout from the changes made in `make.js` in PR 6627, since `stripCommentHeaders` previously relied on the existence of the mode-lines.

I'm assuming that we do want *all* of the code (e.g. the viewer too) to execute in strict mode, hence this patch tweaks `stripCommentHeaders` to make it less greedy.
This commit is contained in:
Jonas Jenwald 2015-11-21 18:45:06 +01:00
parent 373da010ac
commit c310a3790e
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
make.js
View File

@ -606,8 +606,9 @@ target.singlefile = function() {
function stripCommentHeaders(content, filename) { function stripCommentHeaders(content, filename) {
var notEndOfComment = '(?:[^*]|\\*(?!/))+'; var notEndOfComment = '(?:[^*]|\\*(?!/))+';
var reg = new RegExp( var reg = new RegExp(
'\n(?:/\\*' + notEndOfComment + '\\*/\\s*|//(?!#).*\n\\s*)+' + '\n/\\* Copyright' + notEndOfComment + '\\*/\\s*' +
'\'use strict\';', 'g'); '(?:/\\*' + notEndOfComment + '\\*/\\s*|//(?!#).*\n\\s*)*' +
'\\s*\'use strict\';', 'g');
content = content.replace(reg, ''); content = content.replace(reg, '');
return content; return content;
} }