Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #6679 from Snuffleupagus/better-openExternalLinksInNewWindow-deprecation-comments

Browse Source 
Improve the comment and deprecation warning for `PDFJS.openExternalLinksInNewWindow`
This commit is contained in:
Tim van der Meij 2015-11-24 22:38:43 +01:00
commit c280fb516d
2 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/display/api.js
View File

@ -173,6 +173,9 @@ PDFJS.maxCanvasPixels = (PDFJS.maxCanvasPixels === undefined ?
/**
* (Deprecated) Opens external links in a new window if enabled.
* The default behavior opens external links in the PDF.js window.
*
* NOTE: This property has been deprecated, please use
* `PDFJS.externalLinkTarget = PDFJS.LinkTarget.BLANK` instead.
* @var {boolean}
*/
PDFJS.openExternalLinksInNewWindow = (

6
src/shared/util.js
View File

@ -360,10 +360,10 @@ var LinkTargetStringMap = [
];
function isExternalLinkTargetSet() {
//#if GENERIC
//#if !MOZCENTRAL
if (PDFJS.openExternalLinksInNewWindow) {
warn('PDFJS.openExternalLinksInNewWindow is deprecated, ' +
'use PDFJS.externalLinkTarget instead.');
deprecated('PDFJS.openExternalLinksInNewWindow, please use ' +
'"PDFJS.externalLinkTarget = PDFJS.LinkTarget.BLANK" instead.');
if (PDFJS.externalLinkTarget === LinkTarget.NONE) {
PDFJS.externalLinkTarget = LinkTarget.BLANK;
}