Merge pull request #5109 from timvandermeij/strict-equalities-test
Use strict equalities in test/*
This commit is contained in:
commit
c0cbf5f458
@ -70,7 +70,7 @@ window.load = function load() {
|
|||||||
var r = new XMLHttpRequest();
|
var r = new XMLHttpRequest();
|
||||||
r.open('GET', manifestFile, false);
|
r.open('GET', manifestFile, false);
|
||||||
r.onreadystatechange = function loadOnreadystatechange(e) {
|
r.onreadystatechange = function loadOnreadystatechange(e) {
|
||||||
if (r.readyState == 4) {
|
if (r.readyState === 4) {
|
||||||
log('done\n');
|
log('done\n');
|
||||||
manifest = JSON.parse(r.responseText);
|
manifest = JSON.parse(r.responseText);
|
||||||
currentTaskIdx = 0;
|
currentTaskIdx = 0;
|
||||||
@ -132,7 +132,7 @@ function nextTask() {
|
|||||||
}
|
}
|
||||||
|
|
||||||
function continueNextTask() {
|
function continueNextTask() {
|
||||||
if (currentTaskIdx == manifest.length) {
|
if (currentTaskIdx === manifest.length) {
|
||||||
done();
|
done();
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
@ -291,7 +291,7 @@ function nextPage(task, loadError) {
|
|||||||
var initPromise = new Promise(function (resolve) {
|
var initPromise = new Promise(function (resolve) {
|
||||||
resolveInitPromise = resolve;
|
resolveInitPromise = resolve;
|
||||||
});
|
});
|
||||||
if (task.type == 'text') {
|
if (task.type === 'text') {
|
||||||
// using dummy canvas for pdf context drawing operations
|
// using dummy canvas for pdf context drawing operations
|
||||||
if (!dummyCanvas) {
|
if (!dummyCanvas) {
|
||||||
dummyCanvas = document.createElement('canvas');
|
dummyCanvas = document.createElement('canvas');
|
||||||
@ -354,7 +354,7 @@ function sendQuitRequest(cb) {
|
|||||||
var r = new XMLHttpRequest();
|
var r = new XMLHttpRequest();
|
||||||
r.open('POST', '/tellMeToQuit?path=' + escape(appPath), false);
|
r.open('POST', '/tellMeToQuit?path=' + escape(appPath), false);
|
||||||
r.onreadystatechange = function sendQuitRequestOnreadystatechange(e) {
|
r.onreadystatechange = function sendQuitRequestOnreadystatechange(e) {
|
||||||
if (r.readyState == 4) {
|
if (r.readyState === 4) {
|
||||||
if (cb) {
|
if (cb) {
|
||||||
cb();
|
cb();
|
||||||
}
|
}
|
||||||
@ -409,7 +409,7 @@ function send(url, message, callback) {
|
|||||||
r.open('POST', url, true);
|
r.open('POST', url, true);
|
||||||
r.setRequestHeader('Content-Type', 'application/json');
|
r.setRequestHeader('Content-Type', 'application/json');
|
||||||
r.onreadystatechange = function sendTaskResultOnreadystatechange(e) {
|
r.onreadystatechange = function sendTaskResultOnreadystatechange(e) {
|
||||||
if (r.readyState == 4) {
|
if (r.readyState === 4) {
|
||||||
inFlightRequests--;
|
inFlightRequests--;
|
||||||
// Retry until successful
|
// Retry until successful
|
||||||
if (r.status !== 200) {
|
if (r.status !== 200) {
|
||||||
|
@ -10,13 +10,13 @@ describe('function', function() {
|
|||||||
this.addMatchers({
|
this.addMatchers({
|
||||||
toMatchArray: function(expected) {
|
toMatchArray: function(expected) {
|
||||||
var actual = this.actual;
|
var actual = this.actual;
|
||||||
if (actual.length != expected.length) {
|
if (actual.length !== expected.length) {
|
||||||
return false;
|
return false;
|
||||||
}
|
}
|
||||||
for (var i = 0; i < expected.length; i++) {
|
for (var i = 0; i < expected.length; i++) {
|
||||||
var a = actual[i], b = expected[i];
|
var a = actual[i], b = expected[i];
|
||||||
if (isArray(b)) {
|
if (isArray(b)) {
|
||||||
if (a.length != b.length) {
|
if (a.length !== b.length) {
|
||||||
return false;
|
return false;
|
||||||
}
|
}
|
||||||
for (var j = 0; j < a.length; j++) {
|
for (var j = 0; j < a.length; j++) {
|
||||||
|
@ -9,7 +9,7 @@ describe('stream', function() {
|
|||||||
this.addMatchers({
|
this.addMatchers({
|
||||||
toMatchTypedArray: function(expected) {
|
toMatchTypedArray: function(expected) {
|
||||||
var actual = this.actual;
|
var actual = this.actual;
|
||||||
if (actual.length != expected.length) {
|
if (actual.length !== expected.length) {
|
||||||
return false;
|
return false;
|
||||||
}
|
}
|
||||||
for (var i = 0, ii = expected.length; i < ii; i++) {
|
for (var i = 0, ii = expected.length; i < ii; i++) {
|
||||||
|
@ -11,7 +11,7 @@ var TestReporter = function(browser, appPath) {
|
|||||||
r.open('POST', action, true);
|
r.open('POST', action, true);
|
||||||
r.setRequestHeader('Content-Type', 'application/json');
|
r.setRequestHeader('Content-Type', 'application/json');
|
||||||
r.onreadystatechange = function sendTaskResultOnreadystatechange(e) {
|
r.onreadystatechange = function sendTaskResultOnreadystatechange(e) {
|
||||||
if (r.readyState == 4) {
|
if (r.readyState === 4) {
|
||||||
// Retry until successful
|
// Retry until successful
|
||||||
if (r.status !== 200) {
|
if (r.status !== 200) {
|
||||||
send(action, json, cb);
|
send(action, json, cb);
|
||||||
|
Loading…
x
Reference in New Issue
Block a user