Add general iteration support in the RefSet and RefSetCache classes

This patch removes the existing `forEach` methods, in favor of making the classes properly iterable instead. Given that the classes are using a `Set` respectively a `Map` internally, implementing this is very easy/efficient and allows us to simplify some existing code.

src/core/catalog.js

@@ -1040,42 +1040,32 @@ class Catalog {
     return shadow(this, "jsActions", actions);
   }
 
-  fontFallback(id, handler) {
+  async fontFallback(id, handler) {
-    const promises = [];
+    const translatedFonts = await Promise.all(this.fontCache);
-    this.fontCache.forEach(function (promise) {
-      promises.push(promise);
-    });
 
-    return Promise.all(promises).then(translatedFonts => {
     for (const translatedFont of translatedFonts) {
       if (translatedFont.loadedName === id) {
         translatedFont.fallback(handler);
         return;
       }
     }
-    });
   }
 
-  cleanup(manuallyTriggered = false) {
+  async cleanup(manuallyTriggered = false) {
     clearGlobalCaches();
     this.globalImageCache.clear(/* onlyData = */ manuallyTriggered);
     this.pageKidsCountCache.clear();
     this.pageIndexCache.clear();
     this.nonBlendModesSet.clear();
 
-    const promises = [];
+    const translatedFonts = await Promise.all(this.fontCache);
-    this.fontCache.forEach(function (promise) {
-      promises.push(promise);
-    });
 
-    return Promise.all(promises).then(translatedFonts => {
     for (const { dict } of translatedFonts) {
       delete dict.cacheKey;
     }
     this.fontCache.clear();
     this.builtInCMapCache.clear();
     this.standardFontDataCache.clear();
-    });
   }
 
   async getPageDict(pageIndex) {

src/core/evaluator.js

@@ -352,9 +352,9 @@ class PartialEvaluator {
     // When no blend modes exist, there's no need re-fetch/re-parse any of the
     // processed `Ref`s again for subsequent pages. This helps reduce redundant
     // `XRef.fetch` calls for some documents (e.g. issue6961.pdf).
-    processed.forEach(ref => {
+    for (const ref of processed) {
       nonBlendModesSet.put(ref);
-    });
+    }
     return false;
   }
 

src/core/image_utils.js

@@ -179,9 +179,9 @@ class GlobalImageCache {
 
   get _byteSize() {
     let byteSize = 0;
-    this._imageCache.forEach(imageData => {
+    for (const imageData of this._imageCache) {
       byteSize += imageData.byteSize;
-    });
+    }
     return byteSize;
   }
 

src/core/primitives.js

@@ -350,10 +350,8 @@ class RefSet {
     this._set.delete(ref.toString());
   }
 
-  forEach(callback) {
+  [Symbol.iterator]() {
-    for (const ref of this._set.values()) {
+    return this._set.values();
-      callback(ref);
-    }
   }
 
   clear() {
@@ -386,10 +384,8 @@ class RefSetCache {
     this._map.set(ref.toString(), this.get(aliasRef));
   }
 
-  forEach(callback) {
+  [Symbol.iterator]() {
-    for (const value of this._map.values()) {
+    return this._map.values();
-      callback(value);
-    }
   }
 
   clear() {

test/unit/primitives_spec.js

@@ -418,28 +418,41 @@ describe("primitives", function () {
   });
 
   describe("RefSet", function () {
-    it("should have a stored value", function () {
+    const ref1 = Ref.get(4, 2),
-      const ref = Ref.get(4, 2);
+      ref2 = Ref.get(5, 2);
-      const refset = new RefSet();
+    let refSet;
-      refset.put(ref);
-      expect(refset.has(ref)).toBeTruthy();
-    });
-    it("should not have an unknown value", function () {
-      const ref = Ref.get(4, 2);
-      const refset = new RefSet();
-      expect(refset.has(ref)).toBeFalsy();
 
-      refset.put(ref);
+    beforeEach(function () {
-      const anotherRef = Ref.get(2, 4);
+      refSet = new RefSet();
-      expect(refset.has(anotherRef)).toBeFalsy();
+    });
+
+    afterEach(function () {
+      refSet = null;
+    });
+
+    it("should have a stored value", function () {
+      refSet.put(ref1);
+      expect(refSet.has(ref1)).toBeTruthy();
+    });
+
+    it("should not have an unknown value", function () {
+      expect(refSet.has(ref1)).toBeFalsy();
+      refSet.put(ref1);
+      expect(refSet.has(ref2)).toBeFalsy();
+    });
+
+    it("should support iteration", function () {
+      refSet.put(ref1);
+      refSet.put(ref2);
+      expect([...refSet]).toEqual([ref1.toString(), ref2.toString()]);
     });
   });
 
   describe("RefSetCache", function () {
-    const ref1 = Ref.get(4, 2);
+    const ref1 = Ref.get(4, 2),
-    const ref2 = Ref.get(5, 2);
+      ref2 = Ref.get(5, 2),
-    const obj1 = Name.get("foo");
+      obj1 = Name.get("foo"),
-    const obj2 = Name.get("bar");
+      obj2 = Name.get("bar");
     let cache;
 
     beforeEach(function () {
@@ -483,12 +496,7 @@ describe("primitives", function () {
     it("should support iteration", function () {
       cache.put(ref1, obj1);
       cache.put(ref2, obj2);
-
+      expect([...cache]).toEqual([obj1, obj2]);
-      const values = [];
-      cache.forEach(function (value) {
-        values.push(value);
-      });
-      expect(values).toEqual([obj1, obj2]);
     });
   });