Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #16695 from Snuffleupagus/tests-NaN

Browse Source 
Ensure that a test-suite that runs no tests is treated as a failure
This commit is contained in:
Jonas Jenwald 2023-07-16 08:32:43 +02:00 committed by GitHub
commit bd67f7841f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
test/test.mjs
View File

@ -262,11 +262,13 @@ function examineRefImages() {
function startRefTest(masterMode, showRefImages) { function startRefTest(masterMode, showRefImages) {
function finalize() { function finalize() {
stopServer(); stopServer();
let numRuns = 0;
var numErrors = 0; var numErrors = 0;
var numFBFFailures = 0; var numFBFFailures = 0;
var numEqFailures = 0; var numEqFailures = 0;
var numEqNoSnapshot = 0; var numEqNoSnapshot = 0;
sessions.forEach(function (session) { sessions.forEach(function (session) {
numRuns += session.numRuns;
numErrors += session.numErrors; numErrors += session.numErrors;
numFBFFailures += session.numFBFFailures; numFBFFailures += session.numFBFFailures;
numEqFailures += session.numEqFailures; numEqFailures += session.numEqFailures;
@ -274,7 +276,9 @@ function startRefTest(masterMode, showRefImages) {
}); });
var numFatalFailures = numErrors + numFBFFailures; var numFatalFailures = numErrors + numFBFFailures;
console.log(); console.log();
if (numFatalFailures + numEqFailures > 0) { if (!numRuns) {
console.log(`OHNOES! No tests ran!`);
} else if (numFatalFailures + numEqFailures > 0) {
console.log("OHNOES! Some tests failed!"); console.log("OHNOES! Some tests failed!");
if (numErrors > 0) { if (numErrors > 0) {
console.log(" errors: " + numErrors); console.log(" errors: " + numErrors);
@ -348,6 +352,7 @@ function startRefTest(masterMode, showRefImages) {
session.taskResults[item.id] = roundsResults; session.taskResults[item.id] = roundsResults;
session.tasks[item.id] = item; session.tasks[item.id] = item;
}); });
session.numRuns = 0;
session.numErrors = 0; session.numErrors = 0;
session.numFBFFailures = 0; session.numFBFFailures = 0;
session.numEqNoSnapshot = 0; session.numEqNoSnapshot = 0;
@ -608,6 +613,8 @@ function checkRefTestResults(browser, id, results) {
var failed = false; var failed = false;
var session = getSession(browser); var session = getSession(browser);
var task = session.tasks[id]; var task = session.tasks[id];
session.numRuns++;
results.forEach(function (roundResults, round) { results.forEach(function (roundResults, round) {
roundResults.forEach(function (pageResult, page) { roundResults.forEach(function (pageResult, page) {
if (!pageResult) { if (!pageResult) {
@ -773,7 +780,9 @@ function onAllSessionsClosedAfterTests(name) {
}); });
console.log(); console.log();
console.log("Run " + numRuns + " tests"); console.log("Run " + numRuns + " tests");
if (numErrors > 0) { if (!numRuns) {
console.log(`OHNOES! No ${name} tests ran!`);
} else if (numErrors > 0) {
console.log("OHNOES! Some " + name + " tests failed!"); console.log("OHNOES! Some " + name + " tests failed!");
console.log(" " + numErrors + " of " + numRuns + " failed"); console.log(" " + numErrors + " of " + numRuns + " failed");
} else { } else {