Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Re-factor some String.fromCharCode usage in the src/core/binary_cmap.js file

Browse Source 
We can replace one case of `apply` with rest parameters, and avoid doing repeated `String.fromCharCode` calls within a loop.
This commit is contained in:
Jonas Jenwald 2023-04-21 12:10:42 +02:00
parent cabc98f310
commit bc7aa8a585
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/core/binary_cmap.js
View File

@ -32,7 +32,7 @@ function hexToStr(a, size) {
if (size === 3) { if (size === 3) {
return String.fromCharCode(a[0], a[1], a[2], a[3]); return String.fromCharCode(a[0], a[1], a[2], a[3]);
} }
return String.fromCharCode.apply(null, a.subarray(0, size + 1)); return String.fromCharCode(...a.subarray(0, size + 1));
} }
function addHex(a, b, size) { function addHex(a, b, size) {
@ -133,12 +133,12 @@ class BinaryCMapStream {
} }
readString() { readString() {
const len = this.readNumber(); const len = this.readNumber(),
let s = ""; buf = new Array(len);
for (let i = 0; i < len; i++) { for (let i = 0; i < len; i++) {
s += String.fromCharCode(this.readNumber()); buf[i] = this.readNumber();
} }
return s; return String.fromCharCode(...buf);
} }
} }