Sakurai/pdf.js
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Re-factor the toggleButton l10n in the PDFSidebar class

Browse Source 
Rather than "manually" looking up the l10n-string and then updating the button, we can (and probably even should) just update the l10n-id and then trigger proper translation for the button DOM-element.
This commit is contained in:
Jonas Jenwald 2022-09-30 09:56:54 +02:00
parent 0011a747f7
commit bad00f825a
2 changed files with 7 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
web/l10n_utils.js
View File

@ -40,10 +40,6 @@ const DEFAULT_L10N_STRINGS = {
print_progress_percent: "{{progress}}%", print_progress_percent: "{{progress}}%",
"toggle_sidebar.title": "Toggle Sidebar",
"toggle_sidebar_notification2.title":
"Toggle Sidebar (document contains outline/attachments/layers)",
additional_layers: "Additional Layers", additional_layers: "Additional Layers",
page_landmark: "Page {{page}}", page_landmark: "Page {{page}}",
thumb_page_title: "Page {{page}}", thumb_page_title: "Page {{page}}",

13
web/pdf_sidebar.js
View File

@ -307,9 +307,11 @@ class PDFSidebar {
} }
#showUINotification() { #showUINotification() {
this.l10n.get("toggle_sidebar_notification2.title").then(msg => { this.toggleButton.setAttribute(
this.toggleButton.title = msg; "data-l10n-id",
}); "toggle_sidebar_notification2"
);
this.l10n.translate(this.toggleButton);
if (!this.isOpen) { if (!this.isOpen) {
// Only show the notification on the `toggleButton` if the sidebar is // Only show the notification on the `toggleButton` if the sidebar is
@ -326,9 +328,8 @@ class PDFSidebar {
} }
if (reset) { if (reset) {
this.l10n.get("toggle_sidebar.title").then(msg => { this.toggleButton.setAttribute("data-l10n-id", "toggle_sidebar");
this.toggleButton.title = msg; this.l10n.translate(this.toggleButton);
});
} }
} }